From: Shunsuke Mie <mie@igel.co.jp>
To: Zhu Yanjun <zyjzyj2000@gmail.com>
Cc: Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
mie@igel.co.jp
Subject: [PATCH] Provider/rxe: Allocate rxe/ib objs by calloc
Date: Thu, 30 Sep 2021 20:35:27 +0900 [thread overview]
Message-ID: <20210930113527.49659-1-mie@igel.co.jp> (raw)
Some rxe/ib objects are allocated by malloc() and initialize manually
respectively. To prevent a bug caused by memory uninitialization, this
patch change to use calloc().
Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
---
providers/rxe/rxe.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/providers/rxe/rxe.c b/providers/rxe/rxe.c
index 3533a325..788a1bbd 100644
--- a/providers/rxe/rxe.c
+++ b/providers/rxe/rxe.c
@@ -104,7 +104,7 @@ static struct ibv_pd *rxe_alloc_pd(struct ibv_context *context)
struct ib_uverbs_alloc_pd_resp resp;
struct ibv_pd *pd;
- pd = malloc(sizeof(*pd));
+ pd = calloc(1, sizeof(*pd));
if (!pd)
return NULL;
@@ -225,7 +225,7 @@ static struct ibv_mr *rxe_reg_mr(struct ibv_pd *pd, void *addr, size_t length,
struct ib_uverbs_reg_mr_resp resp;
int ret;
- vmr = malloc(sizeof(*vmr));
+ vmr = calloc(1, sizeof(*vmr));
if (!vmr)
return NULL;
@@ -382,7 +382,7 @@ static struct ibv_cq *rxe_create_cq(struct ibv_context *context, int cqe,
struct urxe_create_cq_resp resp = {};
int ret;
- cq = malloc(sizeof(*cq));
+ cq = calloc(1, sizeof(*cq));
if (!cq)
return NULL;
@@ -594,7 +594,7 @@ static struct ibv_srq *rxe_create_srq(struct ibv_pd *pd,
struct urxe_create_srq_resp resp;
int ret;
- srq = malloc(sizeof(*srq));
+ srq = calloc(1, sizeof(*srq));
if (srq == NULL)
return NULL;
@@ -1167,7 +1167,7 @@ static struct ibv_qp *rxe_create_qp(struct ibv_pd *ibpd,
struct rxe_qp *qp;
int ret;
- qp = malloc(sizeof(*qp));
+ qp = calloc(1, sizeof(*qp));
if (!qp)
goto err;
@@ -1659,7 +1659,7 @@ static struct ibv_ah *rxe_create_ah(struct ibv_pd *pd, struct ibv_ah_attr *attr)
return NULL;
}
- ah = malloc(sizeof(*ah));
+ ah = calloc(1, sizeof(*ah));
if (ah == NULL)
return NULL;
--
2.17.1
next reply other threads:[~2021-09-30 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 11:35 Shunsuke Mie [this message]
2021-09-30 12:41 ` Haakon Bugge
2021-09-30 14:39 ` Zhu Yanjun
2021-10-06 8:13 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210930113527.49659-1-mie@igel.co.jp \
--to=mie@igel.co.jp \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®