From: Michel Lespinasse <michel@lespinasse.org>
To: Li RongQing <lirongqing@baidu.com>
Cc: linux-kernel@vger.kernel.org, michel@lespinasse.org
Subject: Re: [PATCH] rbtree: Remove unneeded check condition in rb_find_first
Date: Thu, 30 Sep 2021 15:58:50 -0700 [thread overview]
Message-ID: <20210930225850.GA6434@lespinasse.org> (raw)
In-Reply-To: <1632986196-20074-1-git-send-email-lirongqing@baidu.com>
On Thu, Sep 30, 2021 at 03:16:36PM +0800, Li RongQing wrote:
> the variable c is int type, so change the following condition
>
> if (c <= 0) {
>
> }
> else if (c > 0) {
>
> }
> as:
> if (c <= 0) {
>
> }
> else {
>
> }
>
> Spotted-by: Michel Lespinasse <<michel@lespinasse.org>>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
> include/linux/rbtree.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/rbtree.h b/include/linux/rbtree.h
> index 235047d..d5ac8f7 100644
> --- a/include/linux/rbtree.h
> +++ b/include/linux/rbtree.h
> @@ -294,7 +294,7 @@ static inline void rb_replace_node_cached(struct rb_node *victim,
> if (!c)
> match = node;
> node = node->rb_left;
> - } else if (c > 0) {
> + } else {
> node = node->rb_right;
> }
> }
Looks good to me, thanks for the fix.
Reviewed-by: Michel Lespinasse <michel@lespinasse.org>
--
Michel "walken" Lespinasse
next prev parent reply other threads:[~2021-09-30 23:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 7:16 Li RongQing
2021-09-30 22:58 ` Michel Lespinasse [this message]
2021-10-22 4:19 ` 答复: " Li,Rongqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210930225850.GA6434@lespinasse.org \
--to=michel@lespinasse.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®