From: Alex Williamson <alex.williamson@redhat.com>
To: Ajay Garg <ajaygargnsit@gmail.com>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH] iommu: intel: remove flooding of non-error logs, when new-DMA-PTE is the same as old-DMA-PTE.
Date: Mon, 4 Oct 2021 16:31:46 -0600 [thread overview]
Message-ID: <20211004163146.6b34936b.alex.williamson@redhat.com> (raw)
In-Reply-To: <CAHP4M8Us753hAeoXL7E-4d29rD9+FzUwAqU6gKNmgd8G0CaQQw@mail.gmail.com>
On Sat, 2 Oct 2021 22:48:24 +0530
Ajay Garg <ajaygargnsit@gmail.com> wrote:
> Thanks Lu for the reply.
>
> >
> > Isn't the domain should be switched from a default domain to an
> > unmanaged domain when the device is assigned to the guest?
> >
> > Even you want to r-setup the same mappings, you need to un-map all
> > existing mappings, right?
> >
>
> Hmm, I guess that's a (design) decision the KVM/QEMU/VFIO communities
> need to take.
> May be the patch could suppress the flooding till then?
No, this is wrong. The pte values should not exist, it doesn't matter
that they're the same. Is the host driver failing to remove mappings
and somehow they persist in the new vfio owned domain? There's
definitely a bug beyond logging going on here. Thanks,
Alex
next prev parent reply other threads:[~2021-10-04 22:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 12:40 Ajay Garg
2021-10-02 13:14 ` Lu Baolu
2021-10-02 17:18 ` Ajay Garg
2021-10-04 22:31 ` Alex Williamson [this message]
2021-10-07 9:03 ` Ajay Garg
2021-10-10 6:15 ` Ajay Garg
2021-10-11 6:19 ` Ajay Garg
2021-10-11 14:52 ` Alex Williamson
2021-10-11 18:13 ` Ajay Garg
2021-10-12 14:02 ` Ajay Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211004163146.6b34936b.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=ajaygargnsit@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®