From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5CC6C433EF for ; Mon, 4 Oct 2021 17:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D57261407 for ; Mon, 4 Oct 2021 17:35:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234905AbhJDRhY (ORCPT ); Mon, 4 Oct 2021 13:37:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234757AbhJDRhW (ORCPT ); Mon, 4 Oct 2021 13:37:22 -0400 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A30D9C06174E for ; Mon, 4 Oct 2021 10:35:33 -0700 (PDT) Received: by mail-qt1-x831.google.com with SMTP id c20so16630728qtb.2 for ; Mon, 04 Oct 2021 10:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=s9zoLF/MgNaPjaZR+JeLQsj/a9Rsc/IJzh+CjAnpcGg=; b=OgrydoSelRcLx1oyHyBgH+lLYPFnfnXn8MsSCu4nOKH9ZW3eD1gM/dTR+zwgcEJRou MIvdZcSStbZZxwA144uM1NkUCe4/ji8Ht29uI0DOV1o66aHANeUixv5p+H3NwBM12mLM JDxweIvKdobh3UdofT+4yhL2PpnU5T6agvFmsfu86gFCHlxwwM8ARqd6+8oXAegWLTRE zU/vRetl4pMkjQ/wFlMAEXtgUwvu2PgQWI64WDybo7WtZ20QKnqiFpKU17LDlX+fmaHZ XP05XOs3gzZwnk1pgfkos2ybbmKo/KqbQhpajWJbHX1Sn/g35oubA39bWPoPbLzs3A+i hivQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=s9zoLF/MgNaPjaZR+JeLQsj/a9Rsc/IJzh+CjAnpcGg=; b=QuwwZ1AUIvLNGltxwjL2iCKNdcGrSk9n3dIrF0LUq0/Zh6vnxQ8wGqGo8XjlWfI0lr CVEXQDV5eWOc3gN4SUVOS0mLkuRlKd/d6k2o/gbCzPVhyYSi7cpljkQnc8QuGtZKzNw2 dzjobR8BmRIp/FsLx/rAN3VOlOTVn7A+e+2jH7X21rsIkgVbet+Dn1hlczrtZYCLLBl1 gXfTHxKfSCRim4KH1RZgAEm3O6g69wbnSDWDy99E1wNXH2tM/gfPzmelyjh/kgqdmSfC QszCp4oje/yiDcZRDq+FiqaXZmOsoa2Rmfy6qjRdtOYUbWjE7MCD6l+cLAhcMQMvBQOX hQTQ== X-Gm-Message-State: AOAM531YfMT6YUiVXUp00IW39t9qM+HmI2bWYEWRgd9NKOtAHFy+fQXG KP1o4e9OcHz78puNn+XkqNX1/A== X-Google-Smtp-Source: ABdhPJyuK8QutD+64SmMVldzYIkBdTmala+1kw3pePr14EIL7iYRjW6JUEvfZbsfZjUzTlzz8eJHOg== X-Received: by 2002:a05:622a:164b:: with SMTP id y11mr14777104qtj.310.1633368932754; Mon, 04 Oct 2021 10:35:32 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id j184sm8223325qkd.74.2021.10.04.10.35.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Oct 2021 10:35:32 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1mXRsB-00AXrn-LQ; Mon, 04 Oct 2021 14:35:31 -0300 Date: Mon, 4 Oct 2021 14:35:31 -0300 From: Jason Gunthorpe To: Mark Brown Cc: Florian Fainelli , Lino Sanfilippo , rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, nsaenz@kernel.org, linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, p.rosenberger@kunbus.com, linux-integrity@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] spi: bcm2835: do not unregister controller in shutdown handler Message-ID: <20211004173531.GB3544071@ziepe.ca> References: <20211004131756.GW3544071@ziepe.ca> <20211004154436.GY3544071@ziepe.ca> <20211004165127.GZ3544071@ziepe.ca> <20211004171301.GA3544071@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 04, 2021 at 06:27:29PM +0100, Mark Brown wrote: > On Mon, Oct 04, 2021 at 02:13:01PM -0300, Jason Gunthorpe wrote: > > > I'm kind of surprised a scheme like this didn't involve a FW call > > after Linux is done with the CPUs to quiet all the HW and let it > > sleep, I've built things that way before at least. > > That's a *lot* of code to put in firmware if you can't physically power > most of the system down. Maybe? The chip I worked on we just made a list of register/value pairs that covered all the functional blocks and the FW ran down the list. Mind you the chip was designed that poking ABC to reg 123 turned the unit off no matter what. It didn't have a complex interactive shutdown sequence. Jason