From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 002A8C433EF for ; Tue, 5 Oct 2021 07:52:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D5219610FC for ; Tue, 5 Oct 2021 07:52:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232938AbhJEHya (ORCPT ); Tue, 5 Oct 2021 03:54:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232511AbhJEHyZ (ORCPT ); Tue, 5 Oct 2021 03:54:25 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CE4EC061745; Tue, 5 Oct 2021 00:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Mb1ebH9NpOSymYrwurOQhqV4b/SOhG5oKbLWs3+sfew=; b=eQ40yLk9ADR7QoIBFAGVtqfh1z yFBhjqJavAeCCAC2q1KmrTt8NGc5h4kV3Qt/oBP0X+HCCCdEeRosZIqJQHv9K8lU241tPMEt0G5gU yB8Bj3pmYv+iJApBI1FNtZHArI9U/f4Dl7i15fhMXq4WEvVhYP4VRXboYlyoub2/+O4AqZylpPdFu gxq2H4p9gNXQx70rS3sdPZWm0LEorWFMXpYrDnN2gQ28IM9G7Z4/48H2OEPf0KIUQ2304hHpWmJhv VF1R66f+sQwbJ5iLqyAg2Q/Pgt2T5qnaV96eHMAet5f/4Q8jCiuKCeooSlgkggp7FxjFDRQI7Eh3r nRo7wSyw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mXfD7-0006aO-Vb; Tue, 05 Oct 2021 07:50:11 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 44E8F98631C; Tue, 5 Oct 2021 09:50:01 +0200 (CEST) Date: Tue, 5 Oct 2021 09:50:01 +0200 From: Peter Zijlstra To: Tim Chen Cc: Vincent Guittot , Barry Song <21cnbao@gmail.com>, Dietmar Eggemann , LKML , Ingo Molnar , Aubrey Li , Borislav Petkov , Daniel Bristot de Oliveira , Ben Segall , Catalin Marinas , Greg Kroah-Hartman , Guodong Xu , "H. Peter Anvin" , Jonathan Cameron , Juri Lelli , "Cc: Len Brown" , ACPI Devel Maling List , LAK , Linuxarm , Mark Rutland , Mel Gorman , msys.mizuma@gmail.com, "Zengtao (B)" , "Rafael J. Wysocki" , Steven Rostedt , Barry Song , Sudeep Holla , Thomas Gleixner , "Rafael J. Wysocki" , Valentin Schneider , Will Deacon , x86 , yangyicong Subject: Re: [PATCH RESEND 0/3] Represent cluster topology and enable load balance between clusters Message-ID: <20211005075001.GJ4323@worktop.programming.kicks-ass.net> References: <20210924085104.44806-1-21cnbao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 01, 2021 at 04:22:46PM -0700, Tim Chen wrote: > On Fri, 2021-10-01 at 16:57 +0200, Peter Zijlstra wrote: > > The one questino I have is, do we want default y? > > I also agree that default y is preferable. I'll change at least the x86 one to: default y depends on SMP > > The one nit I have is the Kconfig text, I'm not really sure that's > > clarifying what a cluster is. > > Do you have a preference of a different name other than cluster? > Or simply better documentation on what a cluster is for ARM64 > and x86 in Kconfig? Yes, better wording as to what a cluster is. Currently the x86 and arm64 ones actually differ: x86: help Cluster scheduler support improves the CPU scheduler's decision making when dealing with machines that have clusters of CPUs sharing L2 cache. If unsure say N here. arm64: help Cluster scheduler support improves the CPU scheduler's decision making when dealing with machines that have clusters(sharing internal bus or sharing LLC cache tag). If unsure say N here. (also, all this stuff being replicated across arch/*/Kconfig seems unfortunate)