From: Andrew Morton <akpm@linux-foundation.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] ELF: fix overflow in total mapping size calculation
Date: Tue, 5 Oct 2021 17:21:29 -0700 [thread overview]
Message-ID: <20211005172129.4092cc4148bbcac36a128b55@linux-foundation.org> (raw)
In-Reply-To: <YVmd7D0M6G/DcP4O@localhost.localdomain>
On Sun, 3 Oct 2021 15:11:24 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> Kernel assumes that ELF program headers are ordered by mapping address,
> but doesn't enforce it. It is possible to make mapping size extremely huge
> by simply shuffling first and last PT_LOAD segments.
>
> As long as PT_LOAD segments do not overlap, it is silly to require
> sorting by v_addr anyway because mmap() doesn't care.
>
> Don't assume PT_LOAD segments are sorted and calculate min and max
> addresses correctly.
It sounds good, but why do I have the feeling this will explode in some
unexpected fashion? Because it's elf, and that's what it does :(
next prev parent reply other threads:[~2021-10-06 0:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 12:11 Alexey Dobriyan
2021-10-06 0:21 ` Andrew Morton [this message]
2021-10-07 17:13 ` Alexey Dobriyan
2021-10-06 2:31 ` Kees Cook
2021-10-07 17:20 ` Alexey Dobriyan
2021-10-07 17:40 ` Kees Cook
2021-10-07 18:31 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005172129.4092cc4148bbcac36a128b55@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®