From: Richard Palethorpe <rpalethorpe@suse.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Richard Palethorpe <rpalethorpe@suse.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Stefano Garzarella <sgarzare@redhat.com>,
Arseny Krasnov <arseny.krasnov@kaspersky.com>,
Colin Ian King <colin.king@canonical.com>,
Norbert Slusarek <nslusarek@gmx.net>,
Andra Paraschiv <andraprs@amazon.com>,
Deepa Dinamani <deepa.kernel@gmail.com>,
Willem de Bruijn <willemb@google.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
rpalethorpe@richiejp.com
Subject: [PATCH] vsock: Handle compat 32-bit timeout
Date: Wed, 6 Oct 2021 08:45:47 +0100 [thread overview]
Message-ID: <20211006074547.14724-1-rpalethorpe@suse.com> (raw)
Allow 32-bit timevals to be used with a 64-bit kernel.
This allows the LTP regression test vsock01 to run without
modification in 32-bit compat mode.
Fixes: fe0c72f3db11 ("socket: move compat timeout handling into sock.c")
Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
---
This is one of those fixes where I am not sure if we should just
change the test instead. Because it's not clear if someone is likely
to use vsock's in 32-bit compat mode?
net/vmw_vsock/af_vsock.c | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 3e02cc3b24f8..6e9232adf8d0 100644
--- a/net/vmw_vsock/af_vsock.c
+++ b/net/vmw_vsock/af_vsock.c
@@ -1616,7 +1616,16 @@ static int vsock_connectible_setsockopt(struct socket *sock,
case SO_VM_SOCKETS_CONNECT_TIMEOUT: {
struct __kernel_old_timeval tv;
- COPY_IN(tv);
+ struct old_timeval32 tv32;
+
+ if (in_compat_syscall() && !COMPAT_USE_64BIT_TIME) {
+ COPY_IN(tv32);
+ tv.tv_sec = tv32.tv_sec;
+ tv.tv_usec = tv32.tv_usec;
+ } else {
+ COPY_IN(tv);
+ }
+
if (tv.tv_sec >= 0 && tv.tv_usec < USEC_PER_SEC &&
tv.tv_sec < (MAX_SCHEDULE_TIMEOUT / HZ - 1)) {
vsk->connect_timeout = tv.tv_sec * HZ +
@@ -1694,11 +1703,20 @@ static int vsock_connectible_getsockopt(struct socket *sock,
case SO_VM_SOCKETS_CONNECT_TIMEOUT: {
struct __kernel_old_timeval tv;
+ struct old_timeval32 tv32;
+
tv.tv_sec = vsk->connect_timeout / HZ;
tv.tv_usec =
(vsk->connect_timeout -
tv.tv_sec * HZ) * (1000000 / HZ);
- COPY_OUT(tv);
+
+ if (in_compat_syscall() && !COMPAT_USE_64BIT_TIME) {
+ tv32.tv_sec = (u32)tv.tv_sec;
+ tv32.tv_usec = (u32)tv.tv_usec;
+ COPY_OUT(tv32);
+ } else {
+ COPY_OUT(tv);
+ }
break;
}
default:
--
2.33.0
next reply other threads:[~2021-10-06 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 7:45 Richard Palethorpe [this message]
2021-10-06 7:59 ` Arnd Bergmann
2021-10-06 8:13 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211006074547.14724-1-rpalethorpe@suse.com \
--to=rpalethorpe@suse.com \
--cc=andraprs@amazon.com \
--cc=arnd@arndb.de \
--cc=arseny.krasnov@kaspersky.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=deepa.kernel@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nslusarek@gmx.net \
--cc=rpalethorpe@richiejp.com \
--cc=sgarzare@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®