From: Jan Kara <jack@suse.cz>
To: Ye Bin <yebin10@huawei.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
jack@suse.cz
Subject: Re: [PATCH -next v2 3/6] ext4: compare to local seq and nodename when check conflict
Date: Thu, 7 Oct 2021 14:36:21 +0200 [thread overview]
Message-ID: <20211007123621.GH12712@quack2.suse.cz> (raw)
In-Reply-To: <20210911090059.1876456-4-yebin10@huawei.com>
On Sat 11-09-21 17:00:56, Ye Bin wrote:
> As mmp and check_mmp is point to the same data, so there will never
> detect conflict.
> To solve this issue just compare to local data.
>
> Signed-off-by: Ye Bin <yebin10@huawei.com>
Good spotting! Just one nit below.
> ---
> fs/ext4/mmp.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
> index c781b09a78c9..4433fe7e9e86 100644
> --- a/fs/ext4/mmp.c
> +++ b/fs/ext4/mmp.c
> @@ -154,6 +154,7 @@ static int kmmpd(void *data)
> unsigned long last_update_time;
> unsigned long last_check_time;
> unsigned long diff;
> + char nodename[64];
Perhaps define a constant for the length of nodename and use it here as
well as in the declaration of mmp_struct->mmp_nodename?
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2021-10-07 12:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-11 9:00 [PATCH -next v2 0/6] Fix some issues about mmp Ye Bin
2021-09-11 9:00 ` [PATCH -next v2 1/6] ext4: init seq with random value in kmmpd Ye Bin
2021-10-07 12:26 ` Jan Kara
2021-10-08 1:50 ` yebin
2021-09-11 9:00 ` [PATCH -next v2 2/6] ext4: introduce last_check_time record previous check time Ye Bin
2021-10-07 12:31 ` Jan Kara
2021-10-08 1:56 ` yebin
2021-10-08 2:38 ` yebin
2021-10-12 8:47 ` Jan Kara
2021-10-12 11:46 ` yebin
2021-10-13 9:38 ` Jan Kara
2021-10-13 12:33 ` yebin
2021-10-13 21:41 ` Theodore Ts'o
2021-10-15 3:21 ` Andreas Dilger
2021-10-15 3:21 ` Andreas Dilger
2021-09-11 9:00 ` [PATCH -next v2 3/6] ext4: compare to local seq and nodename when check conflict Ye Bin
2021-10-07 12:36 ` Jan Kara [this message]
2021-09-11 9:00 ` [PATCH -next v2 4/6] ext4: avoid to re-read mmp check data get from page cache Ye Bin
2021-10-07 12:44 ` Jan Kara
2021-10-08 3:52 ` yebin
2021-09-11 9:00 ` [PATCH -next v2 5/6] ext4: avoid to double free s_mmp_bh Ye Bin
2021-09-11 9:00 ` [PATCH -next v2 6/6] ext4: fix possible store wrong check interval value in disk when umount Ye Bin
2021-10-07 13:12 ` Jan Kara
2021-10-08 3:49 ` yebin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007123621.GH12712@quack2.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®