From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9432C433EF for ; Thu, 7 Oct 2021 17:29:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A03A060E09 for ; Thu, 7 Oct 2021 17:29:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242414AbhJGRbg (ORCPT ); Thu, 7 Oct 2021 13:31:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:54442 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242353AbhJGRba (ORCPT ); Thu, 7 Oct 2021 13:31:30 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED31360BD3; Thu, 7 Oct 2021 17:29:34 +0000 (UTC) Date: Thu, 7 Oct 2021 18:33:38 +0100 From: Jonathan Cameron To: Cai Huoqing Cc: Lars-Peter Clausen , , Subject: Re: [PATCH v2 1/2] iio: health: afe4403: Make use of the helper function dev_err_probe() Message-ID: <20211007183338.37c80008@jic23-huawei> In-Reply-To: <20210928014403.1563-1-caihuoqing@baidu.com> References: <20210928014403.1563-1-caihuoqing@baidu.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Sep 2021 09:44:01 +0800 Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing Series applied and pushed out as testing for 0-day to see if it can find anything we missed. Thanks, Jonathan > --- > v1->v2: Remove the separate line of PTR_ERR(). > > drivers/iio/health/afe4403.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/health/afe4403.c b/drivers/iio/health/afe4403.c > index d4921385aaf7..3a8cfb669b25 100644 > --- a/drivers/iio/health/afe4403.c > +++ b/drivers/iio/health/afe4403.c > @@ -487,10 +487,10 @@ static int afe4403_probe(struct spi_device *spi) > } > > afe->regulator = devm_regulator_get(afe->dev, "tx_sup"); > - if (IS_ERR(afe->regulator)) { > - dev_err(afe->dev, "Unable to get regulator\n"); > - return PTR_ERR(afe->regulator); > - } > + if (IS_ERR(afe->regulator)) > + return dev_err_probe(afe->dev, PTR_ERR(afe->regulator), > + "Unable to get regulator\n"); > + > ret = regulator_enable(afe->regulator); > if (ret) { > dev_err(afe->dev, "Unable to enable regulator\n");