From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5053EC433EF for ; Sat, 9 Oct 2021 00:11:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D81A60FC2 for ; Sat, 9 Oct 2021 00:11:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244011AbhJIANO (ORCPT ); Fri, 8 Oct 2021 20:13:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243988AbhJIANL (ORCPT ); Fri, 8 Oct 2021 20:13:11 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0F58C061570 for ; Fri, 8 Oct 2021 17:11:15 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id s6-20020a254506000000b005b6b6434cd6so14645186yba.9 for ; Fri, 08 Oct 2021 17:11:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=reply-to:date:in-reply-to:message-id:mime-version:references :subject:from:to:cc; bh=bAloFfewj/zQRYhL5ulk5e0QyHM9EAunSNgXmDCR8AM=; b=ST0iL+WBV2iExe7rpojaTs4LjOuY0fc83FuN072lnEaXnt15bunbZZxjQIpMpHk9Az pADA8vjy5X05YVjPEyR2dJhczHcLph93LPTl/FDMc5XqqvXOu0+emZe6f+l6d/0qE8eD YXCwVZPS1e3ImmfezavyIEMi22XQV8lCVEV0cvoFpHRpFjnKqRGsRxobytIg6KWRRaAo 9LCpz+qqDho/SaSTJ0fvl8nx5o51AstfZiaWitJT5cVihQ4ZWmNvMwcYFPXxCWKw9xqs 9t5joeDe09xEjni5/DNRH/qv0/YdtycZ2Qcm5Q0IIisvoZM6jRESnhO56J0slezWX3Yq X33Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:reply-to:date:in-reply-to:message-id :mime-version:references:subject:from:to:cc; bh=bAloFfewj/zQRYhL5ulk5e0QyHM9EAunSNgXmDCR8AM=; b=1vBhirqqBiUK+jRZITAXGQkGv2YlzVxHvtv7CfUXADGAfikGcmgEoGbQVO/flFu2JM u2bkOoP/0MrTwBxrKdBX/42aptCbLa+5eIw/nsm5dnLjD+XYjgY4hm/HzlrzXazUxqTa zHafrLtc6BJS34lorC37xl99Zpdv1MkIZgONCkvzgPN4H2kVSaW57vq88AshNl2ayveG BE01rI5aiwY36edve1DSQNvLp7bU2n0XZtMjRN4HOJiWlUt5ADPVjtgneHGbyXWfrS2r 21Tkv8PYBxiPNmMVr9WV1Mj3wmZKXKEAsl/dsDyUT/dRO9mogqdSIs6x0knNotCdPMvH U3bw== X-Gm-Message-State: AOAM532q5Mz9kT1Vn28tYm2eXflOhcBPN7quow1oDFqMTcU5MtUVUj67 AZSWs4Py0v4ceTsx4rHjnaaHIUIiWt4= X-Google-Smtp-Source: ABdhPJzaXyLqc9LGIGZZ0X+2cVMG5q4bA4joIE0G1sjVHAYtPKe19e3qhXZKrHz4zpJSfPstsB49oxJ0V/4= X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:90:200:e39b:6333:b001:cb]) (user=seanjc job=sendgmr) by 2002:a25:6115:: with SMTP id v21mr6954932ybb.462.1633738275190; Fri, 08 Oct 2021 17:11:15 -0700 (PDT) Reply-To: Sean Christopherson Date: Fri, 8 Oct 2021 17:11:05 -0700 In-Reply-To: <20211009001107.3936588-1-seanjc@google.com> Message-Id: <20211009001107.3936588-3-seanjc@google.com> Mime-Version: 1.0 References: <20211009001107.3936588-1-seanjc@google.com> X-Mailer: git-send-email 2.33.0.882.g93a45727a2-goog Subject: [PATCH 2/4] KVM: VMX: Unregister posted interrupt wakeup handler on hardware unsetup From: Sean Christopherson To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, Paolo Bonzini Cc: "H. Peter Anvin" , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Unregister KVM's posted interrupt wakeup handler during unsetup so that a spurious interrupt that arrives after kvm_intel.ko is unloaded doesn't call into freed memory. Fixes: bf9f6ac8d749 ("KVM: Update Posted-Interrupts Descriptor when vCPU is blocked") Cc: stable@vger.kernel.org Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 1c8b2b6e7ed9..bfdcdb399212 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -7553,6 +7553,8 @@ static void vmx_migrate_timers(struct kvm_vcpu *vcpu) static void hardware_unsetup(void) { + kvm_set_posted_intr_wakeup_handler(NULL); + if (nested) nested_vmx_hardware_unsetup(); @@ -7881,8 +7883,6 @@ static __init int hardware_setup(void) vmx_x86_ops.request_immediate_exit = __kvm_request_immediate_exit; } - kvm_set_posted_intr_wakeup_handler(pi_wakeup_handler); - kvm_mce_cap_supported |= MCG_LMCE_P; if (pt_mode != PT_MODE_SYSTEM && pt_mode != PT_MODE_HOST_GUEST) @@ -7906,6 +7906,9 @@ static __init int hardware_setup(void) r = alloc_kvm_area(); if (r) nested_vmx_hardware_unsetup(); + + kvm_set_posted_intr_wakeup_handler(pi_wakeup_handler); + return r; } -- 2.33.0.882.g93a45727a2-goog