From: "Pali Rohár" <pali@kernel.org>
To: Martin Kepplinger <martink@posteo.de>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
angus@akkea.ca, linux-kernel@vger.kernel.org,
kay.sievers@vrfy.org, lennart@poettering.net, harald@redhat.com,
gregkh@linuxfoundation.org, david@fubar.dk, tytso@mit.edu,
alan@lxorguk.ukuu.org.uk, akpm@linux-foundation.org
Subject: Re: [PATCH] fs: fat: Make the volume label writable when mounted
Date: Sun, 10 Oct 2021 14:18:16 +0200 [thread overview]
Message-ID: <20211010121816.fdvn6uiiteszbnql@pali> (raw)
In-Reply-To: <874k9pccdf.fsf@mail.parknet.co.jp>
Hello!
On Sunday 10 October 2021 21:06:52 OGAWA Hirofumi wrote:
> > diff --git a/include/uapi/linux/msdos_fs.h b/include/uapi/linux/msdos_fs.h
> > index a5773899f4d9..b666bca09238 100644
> > --- a/include/uapi/linux/msdos_fs.h
> > +++ b/include/uapi/linux/msdos_fs.h
> > @@ -104,6 +104,7 @@ struct __fat_dirent {
> > #define FAT_IOCTL_SET_ATTRIBUTES _IOW('r', 0x11, __u32)
> > /*Android kernel has used 0x12, so we use 0x13*/
> > #define FAT_IOCTL_GET_VOLUME_ID _IOR('r', 0x13, __u32)
> > +#define VFAT_IOCTL_SET_LABEL _IOW('r', 0x14, __u32)
>
> maybe FAT_IOCTL_SET_LABEL is better.
Please do not introduce a new fs specific ioctls. There is already
vfs-agnostic FS_IOC_SETFSLABEL ioctl, look at manpage:
https://man7.org/linux/man-pages/man2/ioctl_fslabel.2.html
I have WIP patches which adds support for FS_IOC_SETFSLABEL ioctl into
kernel vfat driver. But it is not possible to implement this ioctl
properly until issues with encoding are fixed in vfat driver. Some of
dependency patches I have sent to ML as RFC series:
https://lore.kernel.org/lkml/20210808162453.1653-1-pali@kernel.org/
If you have a time and motivation, I can send you my unfinished WIP
patches which implements FS_IOC_SETFSLABEL ioctl for vfat.
next prev parent reply other threads:[~2021-10-10 12:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 9:56 Martin Kepplinger
2021-10-07 10:46 ` Greg KH
2021-10-10 12:06 ` OGAWA Hirofumi
2021-10-10 12:18 ` Pali Rohár [this message]
2021-10-10 12:36 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211010121816.fdvn6uiiteszbnql@pali \
--to=pali@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=angus@akkea.ca \
--cc=david@fubar.dk \
--cc=gregkh@linuxfoundation.org \
--cc=harald@redhat.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=kay.sievers@vrfy.org \
--cc=lennart@poettering.net \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®