From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH 08/11] staging: r8188eu: remove odm hct test info
Date: Sun, 10 Oct 2021 19:52:01 +0200 [thread overview]
Message-ID: <20211010175204.24029-8-martin@kaiser.cx> (raw)
In-Reply-To: <20211010175204.24029-1-martin@kaiser.cx>
The "in hct test" variable is never set, it's always 0.
Remove the variable and fix up the one place where it was used.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/hal/odm.c | 3 ---
drivers/staging/r8188eu/hal/odm_HWConfig.c | 2 +-
drivers/staging/r8188eu/include/odm.h | 2 --
3 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c
index f76bdf3d9a80..c094cffb9e6a 100644
--- a/drivers/staging/r8188eu/hal/odm.c
+++ b/drivers/staging/r8188eu/hal/odm.c
@@ -246,9 +246,6 @@ void ODM_CmnInfoInit(struct odm_dm_struct *pDM_Odm, enum odm_common_info_def Cmn
case ODM_CMNINFO_EXT_TRSW:
pDM_Odm->ExtTRSW = (u8)Value;
break;
- case ODM_CMNINFO_BINHCT_TEST:
- pDM_Odm->bInHctTest = (bool)Value;
- break;
/* To remove the compiler warning, must add an empty default statement to handle the other values. */
default:
/* do nothing */
diff --git a/drivers/staging/r8188eu/hal/odm_HWConfig.c b/drivers/staging/r8188eu/hal/odm_HWConfig.c
index 2ae1a001d339..8e419fd88a12 100644
--- a/drivers/staging/r8188eu/hal/odm_HWConfig.c
+++ b/drivers/staging/r8188eu/hal/odm_HWConfig.c
@@ -143,7 +143,7 @@ static void odm_RxPhyStatus92CSeries_Parsing(struct odm_dm_struct *dm_odm,
if (pPktinfo->bPacketMatchBSSID) {
u8 SQ, SQ_rpt;
- if (pPhyInfo->RxPWDBAll > 40 && !dm_odm->bInHctTest) {
+ if (pPhyInfo->RxPWDBAll > 40) {
SQ = 100;
} else {
SQ_rpt = pPhyStaRpt->cck_sig_qual_ofdm_pwdb_all;
diff --git a/drivers/staging/r8188eu/include/odm.h b/drivers/staging/r8188eu/include/odm.h
index a4e5d4f9f0b9..462424f0a49b 100644
--- a/drivers/staging/r8188eu/include/odm.h
+++ b/drivers/staging/r8188eu/include/odm.h
@@ -271,7 +271,6 @@ enum odm_common_info_def {
ODM_CMNINFO_EXT_LNA, /* true */
ODM_CMNINFO_EXT_PA,
ODM_CMNINFO_EXT_TRSW,
- ODM_CMNINFO_BINHCT_TEST,
/* HOOK BEFORE REG INIT----------- */
/* Dynamic value: */
@@ -655,7 +654,6 @@ struct odm_dm_struct {
u8 ExtPA;
/* with external TRSW NO/Yes = 0/1 */
u8 ExtTRSW;
- bool bInHctTest;
u32 BK_SupportAbility;
u8 AntDivType;
--
2.20.1
next prev parent reply other threads:[~2021-10-10 17:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 17:51 [PATCH 01/11] staging: r8188eu: remove an unused define Martin Kaiser
2021-10-10 17:51 ` [PATCH 02/11] staging: r8188eu: remove specific device table Martin Kaiser
2021-10-10 17:51 ` [PATCH 03/11] staging: r8188eu: RfOnOffDetect is unused Martin Kaiser
2021-10-10 17:51 ` [PATCH 04/11] staging: r8188eu: remove odm fab version info Martin Kaiser
2021-10-10 17:51 ` [PATCH 05/11] staging: r8188eu: remove odm cut " Martin Kaiser
2021-10-10 17:51 ` [PATCH 06/11] staging: r8188eu: remove odm dualmac smart concurrent info Martin Kaiser
2021-10-10 17:52 ` [PATCH 07/11] staging: r8188eu: remove odm wifi test info Martin Kaiser
2021-10-10 17:52 ` Martin Kaiser [this message]
2021-10-10 17:52 ` [PATCH 09/11] staging: r8188eu: remove odm ext trsw info Martin Kaiser
2021-10-10 17:52 ` [PATCH 10/11] staging: r8188eu: remove odm ext pa info Martin Kaiser
2021-10-10 17:52 ` [PATCH 11/11] staging: r8188eu: remove odm ext lna info Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211010175204.24029-8-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®