From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A9DAC433F5 for ; Mon, 11 Oct 2021 02:59:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 009B160F38 for ; Mon, 11 Oct 2021 02:59:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233424AbhJKDBk (ORCPT ); Sun, 10 Oct 2021 23:01:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:59246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230273AbhJKDBi (ORCPT ); Sun, 10 Oct 2021 23:01:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 93D666054F; Mon, 11 Oct 2021 02:59:38 +0000 (UTC) Date: Sun, 10 Oct 2021 22:59:36 -0400 From: Steven Rostedt To: Gang Li Cc: mingo@redhat.com, akpm@linux-foundation.org, vbabka@suse.cz, axelrasmussen@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] mm: mmap_lock: remove "\n" in TP_printk and use DECLARE_EVENT_CLASS Message-ID: <20211010225936.2f97d165@oasis.local.home> In-Reply-To: <20211011021124.86248-1-ligang.bdlg@bytedance.com> References: <20211011021124.86248-1-ligang.bdlg@bytedance.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 11 Oct 2021 10:11:24 +0800 Gang Li wrote: > Ftrace core will add "\n" automatically on print. "\n" in TP_printk > will create blank line, so remove it. > > By using DECLARE_EVENT_CLASS and TRACE_EVENT_FN, we can save a lot > of space from duplicate code. Why did you send this? It should be two patches, not one. The rule is, every commit does one thing. Now you made this patch do two. Andrew already pulled in the other two patches. I don't think this one is appropriate, and should be discarded. -- Steve > > Signed-off-by: Gang Li