From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tom Zanussi <zanussi@kernel.org>,
Tzvetomir Stoyanov <tz.stoyanov@gmail.com>,
Yordan Karadzhov <y.karadz@gmail.com>
Subject: Re: [PATCH v2] tracing: Fix event probe removal from dynamic events
Date: Wed, 13 Oct 2021 11:09:59 -0400 [thread overview]
Message-ID: <20211013110959.5c4d294d@gandalf.local.home> (raw)
In-Reply-To: <20211013233244.46341468a06ba43895b99c0e@kernel.org>
On Wed, 13 Oct 2021 23:32:44 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > Then the following should work:
> >
> > # echo '-:hrstate timer/hrtimer_cancel state=+0x38($hrtimer):u8' >> dynamic_events
> > # echo '-:eprobes/hrstate timer.hrtimer_cancel state=+0x38($hrtimer):u8' >> dynamic_events
> > # echo '-:eprobes/hrstate timer.hrtimer_cancel' >> dynamic_events
> > # echo '-:eprobes/hrstate' >> dynamic_events
>
> Agreed.
>
> >
> > But the following will not work:
> >
> > # echo '-:hrstate state=+0x38($hrtimer):u8' >> dynamic_events
> > # echo '-:hrstate timer.hrtimer_cancel state=+0x38($hrtimer):u8' >> dynamic_events
> > # echo '-:hrstate timer.hrtimer_cancel' >> dynamic_events
>
> The first one is agreed. But the rest 2 cases should work because it just omits the
> group name. At least {k,u}probe events work.
>
> > Should this work?
> >
> > # echo '-:hrstate' >> dynamic_events
>
> Yes. In this case, all dynamic events which have "hrstate" event name are removed.
Thanks for the feedback. I'll update it.
-- Steve
prev parent reply other threads:[~2021-10-13 15:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 12:19 Steven Rostedt
2021-10-12 14:31 ` Masami Hiramatsu
2021-10-12 16:03 ` Steven Rostedt
2021-10-12 22:42 ` Masami Hiramatsu
2021-10-13 0:08 ` Steven Rostedt
2021-10-13 14:42 ` Masami Hiramatsu
2021-10-13 16:53 ` Steven Rostedt
2021-10-12 22:46 ` Masami Hiramatsu
2021-10-13 0:15 ` Steven Rostedt
2021-10-13 14:32 ` Masami Hiramatsu
2021-10-13 15:09 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211013110959.5c4d294d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=tz.stoyanov@gmail.com \
--cc=y.karadz@gmail.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®