From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9423EC433EF for ; Wed, 13 Oct 2021 16:47:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B68E60EB4 for ; Wed, 13 Oct 2021 16:47:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232543AbhJMQti (ORCPT ); Wed, 13 Oct 2021 12:49:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:49068 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229559AbhJMQth (ORCPT ); Wed, 13 Oct 2021 12:49:37 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4D9A360E54; Wed, 13 Oct 2021 16:47:33 +0000 (UTC) Date: Wed, 13 Oct 2021 12:47:31 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: Song Liu , linux-kernel@vger.kernel.org, kernel-team@fb.com, acme@kernel.org, mingo@redhat.com, Andrii Nakryiko , KP Singh Subject: Re: [PATCH] perf/core: allow ftrace for functions in kernel/event/core.c Message-ID: <20211013124731.1a8a48ac@gandalf.local.home> In-Reply-To: References: <20211006210732.2826289-1-songliubraving@fb.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Oct 2021 14:42:21 +0200 Peter Zijlstra wrote: > On Wed, Oct 06, 2021 at 02:07:32PM -0700, Song Liu wrote: > > It is useful to trace functions in kernel/event/core.c. Allow ftrace for > > them by removing $(CC_FLAGS_FTRACE) from Makefile. > > > > --- > > We had some discussions about this last year [1]. Seems that enabling > > ftrace in kernel/events won't really cause fatal recursion in the tests. > > Shall we give it another try? > > I suppose we can give it a go.. Did you want me to pull this into my tree? My tests usually stress perf along with ftrace. -- Steve