From: Andrew Halaney <ahalaney@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: rostedt@goodmis.org, bp@suse.de, rdunlap@infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init: Make unknown command line param message clearer
Date: Thu, 14 Oct 2021 07:47:53 -0500 [thread overview]
Message-ID: <20211014124753.wng5iuzluukz4val@halaneylaptop> (raw)
In-Reply-To: <20211013161259.39e88182200b7a582c0cf632@linux-foundation.org>
On Wed, Oct 13, 2021 at 04:12:59PM -0700, Andrew Morton wrote:
> On Wed, 13 Oct 2021 17:35:02 -0500 Andrew Halaney <ahalaney@redhat.com> wrote:
>
> > The prior message is confusing users, which is the exact opposite of the
> > goal. If the message is being seen, one of the following situations is
> > happening:
> >
> > 1. the param is misspelled
> > 2. the param is not valid due to the kernel configuration
> > 3. the param is intended for init but isn't after the '--'
> > delineator on the command line
> >
> > To make that more clear to the user, explicitly mention "kernel command
> > line" and also note that the params are still passed to user space to
> > avoid causing any alarm over params intended for init.
> >
> > Fixes: 86d1919a4fb0 ("init: print out unknown kernel parameters")
> > Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
>
> Thanks.
>
> BTW, I'm still sitting on your "init/main.c: silence some
> -Wunused-parameter warnings", awaiting a response to Rasmus's
> suggestion:
> https://lkml.kernel.org/r/f06b8308-645b-031b-f9c6-b92400a269aa@rasmusvillemoes.dk
>
Whoops, that got caught in spam (along with rostedt's replies
yesterday... darn gmail). Let me add looking at that to the todo list,
thanks Andrew!
next prev parent reply other threads:[~2021-10-14 12:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 22:35 Andrew Halaney
2021-10-13 22:49 ` Randy Dunlap
2021-10-13 23:12 ` Andrew Morton
2021-10-14 12:47 ` Andrew Halaney [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-10-12 21:35 Andrew Halaney
2021-10-13 0:01 ` Steven Rostedt
2021-10-13 0:18 ` Randy Dunlap
2021-10-13 0:22 ` Steven Rostedt
2021-10-13 12:56 ` Andrew Halaney
2021-10-13 13:03 ` Steven Rostedt
2021-10-13 13:10 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014124753.wng5iuzluukz4val@halaneylaptop \
--to=ahalaney@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®