From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6462C433EF for ; Sat, 16 Oct 2021 09:32:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F87560F23 for ; Sat, 16 Oct 2021 09:32:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243936AbhJPJer (ORCPT ); Sat, 16 Oct 2021 05:34:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235331AbhJPJeq (ORCPT ); Sat, 16 Oct 2021 05:34:46 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56436C061570 for ; Sat, 16 Oct 2021 02:32:38 -0700 (PDT) Received: from martin by viti.kaiser.cx with local (Exim 4.89) (envelope-from ) id 1mbg3O-00031m-A5; Sat, 16 Oct 2021 11:32:34 +0200 Date: Sat, 16 Oct 2021 11:32:34 +0200 From: Martin Kaiser To: Michael Straube Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] staging: r8188eu: remove ODM_SingleDualAntennaDefaultSetting() Message-ID: <20211016093234.dojgrummv3pmj23c@viti.kaiser.cx> References: <20211015163507.9091-1-straube.linux@gmail.com> <20211015163507.9091-3-straube.linux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211015163507.9091-3-straube.linux@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: Martin Kaiser Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thus wrote Michael Straube (straube.linux@gmail.com): > Function ODM_SingleDualAntennaDefaultSetting() is not used, > remove it. > Signed-off-by: Michael Straube > --- > drivers/staging/r8188eu/hal/odm.c | 11 ----------- > drivers/staging/r8188eu/include/odm.h | 2 -- > 2 files changed, 13 deletions(-) > diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c > index 627213392795..030bc7bd9905 100644 > --- a/drivers/staging/r8188eu/hal/odm.c > +++ b/drivers/staging/r8188eu/hal/odm.c > @@ -1190,14 +1190,3 @@ u32 ConvertTo_dB(u32 Value) > return dB; > } > - > -/* Description: */ > -/* Set Single/Dual Antenna default setting for products that do not do detection in advance. */ > -/* Added by Joseph, 2012.03.22 */ > -void ODM_SingleDualAntennaDefaultSetting(struct odm_dm_struct *pDM_Odm) > -{ > - struct sw_ant_switch *pDM_SWAT_Table = &pDM_Odm->DM_SWAT_Table; > - > - pDM_SWAT_Table->ANTA_ON = true; > - pDM_SWAT_Table->ANTB_ON = true; ANTA_ON and ANTB_ON can now be removed from struct sw_ant_switch.