From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Michael Straube <straube.linux@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH 2/3] staging: r8188eu: Makefile: don't overwrite global settings
Date: Sat, 16 Oct 2021 19:35:43 +0200 [thread overview]
Message-ID: <20211016173544.25376-3-martin@kaiser.cx> (raw)
In-Reply-To: <20211016173544.25376-1-martin@kaiser.cx>
Remove settings from the Makefile that are set by higher-level Makefiles.
Some of those settings might have been useful when the driver was
maintained out of tree.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/Makefile | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile
index fccf7e6d1520..8294fb69ecf9 100644
--- a/drivers/staging/r8188eu/Makefile
+++ b/drivers/staging/r8188eu/Makefile
@@ -1,8 +1,3 @@
-SHELL := /bin/bash
-EXTRA_CFLAGS += $(USER_EXTRA_CFLAGS)
-EXTRA_CFLAGS += -O1
-
-ccflags-y += -D__CHECK_ENDIAN__
OUTSRC_FILES := \
hal/HalHWImg8188E_MAC.o \
@@ -46,15 +41,6 @@ _OS_INTFS_FILES := \
_HAL_INTFS_FILES += $(OUTSRC_FILES)
-SUBARCH := $(shell uname -m | sed -e "s/i.86/i386/; s/ppc.*/powerpc/; s/armv.l/arm/; s/aarch64/arm64/;")
-
-ARCH ?= $(SUBARCH)
-CROSS_COMPILE ?=
-KVER ?= $(if $(KERNELRELEASE),$(KERNELRELEASE),$(shell uname -r))
-KSRC ?= $(if $(KERNEL_SRC),$(KERNEL_SRC),/lib/modules/$(KVER)/build)
-MODDESTDIR := /lib/modules/$(KVER)/kernel/drivers/net/wireless
-INSTALL_PREFIX :=
-
rtk_core := \
core/rtw_ap.o \
core/rtw_br_ext.o \
--
2.20.1
next prev parent reply other threads:[~2021-10-16 17:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-16 17:35 [PATCH 0/3] staging: r8188eu: clean up the Makefile Martin Kaiser
2021-10-16 17:35 ` [PATCH 1/3] staging: r8188eu: Makefile: remove unused driver config Martin Kaiser
2021-10-17 12:15 ` Michael Straube
2021-10-16 17:35 ` Martin Kaiser [this message]
2021-10-17 12:18 ` [PATCH 2/3] staging: r8188eu: Makefile: don't overwrite global settings Michael Straube
2021-10-17 17:46 ` Martin Kaiser
2021-10-17 20:46 ` Michael Straube
2021-10-18 14:52 ` Greg Kroah-Hartman
2021-10-18 22:33 ` Michael Straube
2021-10-18 14:46 ` Greg Kroah-Hartman
2021-10-16 17:35 ` [PATCH 3/3] staging: r8188eu: Makefile: use one file list Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211016173544.25376-3-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®