From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4412C433FE for ; Sun, 17 Oct 2021 11:50:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8977961247 for ; Sun, 17 Oct 2021 11:50:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237837AbhJQLw0 (ORCPT ); Sun, 17 Oct 2021 07:52:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:33318 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234082AbhJQLwY (ORCPT ); Sun, 17 Oct 2021 07:52:24 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1685C60F70; Sun, 17 Oct 2021 11:50:09 +0000 (UTC) Date: Sun, 17 Oct 2021 12:54:24 +0100 From: Jonathan Cameron To: Cai Huoqing Cc: Linus Walleij , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , "Pengutronix Kernel Team" , Fabio Estevam , "NXP Linux Team" , Vladimir Zapolskiy , "Neil Armstrong" , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , "Bjorn Andersson" , Heiko Stuebner , Philipp Zabel , , , , , , Subject: Re: [PATCH v4 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Message-ID: <20211017125424.3b9a205a@jic23-huawei> In-Reply-To: <20211008092858.495-1-caihuoqing@baidu.com> References: <20211008092858.495-1-caihuoqing@baidu.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 8 Oct 2021 17:28:49 +0800 Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing Hi Cai, Series applied to the iio-togreg branch of iio.git and pushed out as testing for 0-day to poke at it and see if it can find any problems we missed. Thanks, Jonathan > --- > v1->v2: Remove the separate line of PTR_ERR(). > v2: Reviewed-by: Linus Walleij > > v2->v3: Handle platform_get_irq_byname() that returns -EPROBE_DEFER. > > drivers/iio/adc/ab8500-gpadc.c | 22 +++++++++------------- > 1 file changed, 9 insertions(+), 13 deletions(-) > > diff --git a/drivers/iio/adc/ab8500-gpadc.c b/drivers/iio/adc/ab8500-gpadc.c > index 7b5212ba5501..4c46a201d4ef 100644 > --- a/drivers/iio/adc/ab8500-gpadc.c > +++ b/drivers/iio/adc/ab8500-gpadc.c > @@ -1103,17 +1103,15 @@ static int ab8500_gpadc_probe(struct platform_device *pdev) > return ret; > > gpadc->irq_sw = platform_get_irq_byname(pdev, "SW_CONV_END"); > - if (gpadc->irq_sw < 0) { > - dev_err(dev, "failed to get platform sw_conv_end irq\n"); > - return gpadc->irq_sw; > - } > + if (gpadc->irq_sw < 0) > + return dev_err_probe(dev, gpadc->irq_sw, > + "failed to get platform sw_conv_end irq\n"); > > if (is_ab8500(gpadc->ab8500)) { > gpadc->irq_hw = platform_get_irq_byname(pdev, "HW_CONV_END"); > - if (gpadc->irq_hw < 0) { > - dev_err(dev, "failed to get platform hw_conv_end irq\n"); > - return gpadc->irq_hw; > - } > + if (gpadc->irq_hw < 0) > + return dev_err_probe(dev, gpadc->irq_hw, > + "failed to get platform hw_conv_end irq\n"); > } else { > gpadc->irq_hw = 0; > } > @@ -1146,11 +1144,9 @@ static int ab8500_gpadc_probe(struct platform_device *pdev) > > /* The VTVout LDO used to power the AB8500 GPADC */ > gpadc->vddadc = devm_regulator_get(dev, "vddadc"); > - if (IS_ERR(gpadc->vddadc)) { > - ret = PTR_ERR(gpadc->vddadc); > - dev_err(dev, "failed to get vddadc\n"); > - return ret; > - } > + if (IS_ERR(gpadc->vddadc)) > + return dev_err_probe(dev, PTR_ERR(gpadc->vddadc), > + "failed to get vddadc\n"); > > ret = regulator_enable(gpadc->vddadc); > if (ret) {