From: Neil Armstrong <narmstrong@baylibre.com>
To: tomba@kernel.org
Cc: linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, khilman@baylibre.com,
Benoit Parrot <bparrot@ti.com>,
Neil Armstrong <narmstrong@baylibre.com>
Subject: [PATCH v6 8/9] drm/omap: add plane_atomic_print_state support
Date: Mon, 18 Oct 2021 16:28:41 +0200 [thread overview]
Message-ID: <20211018142842.2511200-9-narmstrong@baylibre.com> (raw)
In-Reply-To: <20211018142842.2511200-1-narmstrong@baylibre.com>
From: Benoit Parrot <bparrot@ti.com>
Now that we added specific item to our subclassed drm_plane_state
we can add omap_plane_atomic_print_state() helper to dump out our own
driver specific plane state.
Signed-off-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
drivers/gpu/drm/omapdrm/omap_plane.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c
index ce5ed45401fb..5001c8354e4f 100644
--- a/drivers/gpu/drm/omapdrm/omap_plane.c
+++ b/drivers/gpu/drm/omapdrm/omap_plane.c
@@ -348,6 +348,21 @@ omap_plane_atomic_duplicate_state(struct drm_plane *plane)
return &state->base;
}
+static void omap_plane_atomic_print_state(struct drm_printer *p,
+ const struct drm_plane_state *state)
+{
+ struct omap_plane_state *omap_state = to_omap_plane_state(state);
+
+ drm_printf(p, "\toverlay=%s\n", omap_state->overlay ?
+ omap_state->overlay->name : "(null)");
+ if (omap_state->overlay) {
+ drm_printf(p, "\t\tidx=%d\n", omap_state->overlay->idx);
+ drm_printf(p, "\t\toverlay_id=%d\n",
+ omap_state->overlay->id);
+ drm_printf(p, "\t\tcaps=0x%x\n", omap_state->overlay->caps);
+ }
+}
+
static int omap_plane_atomic_set_property(struct drm_plane *plane,
struct drm_plane_state *state,
struct drm_property *property,
@@ -387,6 +402,7 @@ static const struct drm_plane_funcs omap_plane_funcs = {
.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
.atomic_set_property = omap_plane_atomic_set_property,
.atomic_get_property = omap_plane_atomic_get_property,
+ .atomic_print_state = omap_plane_atomic_print_state,
};
static bool omap_plane_supports_yuv(struct drm_plane *plane)
--
2.25.1
next prev parent reply other threads:[~2021-10-18 14:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 14:28 [PATCH v6 0/9] drm/omap: Add virtual-planes support Neil Armstrong
2021-10-18 14:28 ` [PATCH v6 1/9] drm/omap: add sanity plane state check Neil Armstrong
2021-10-27 8:29 ` Tomi Valkeinen
2021-10-27 8:30 ` Tomi Valkeinen
2021-11-09 13:10 ` Neil Armstrong
2021-10-18 14:28 ` [PATCH v6 2/9] drm/omap: Add ability to check if requested plane modes can be supported Neil Armstrong
2021-10-27 8:34 ` Tomi Valkeinen
2021-10-18 14:28 ` [PATCH v6 3/9] drm/omap: Add ovl checking funcs to dispc_ops Neil Armstrong
2021-10-27 8:35 ` Tomi Valkeinen
2021-10-18 14:28 ` [PATCH v6 4/9] drm/omap: introduce omap_hw_overlay Neil Armstrong
2021-10-27 10:50 ` Tomi Valkeinen
2021-10-18 14:28 ` [PATCH v6 5/9] drm/omap: omap_plane: subclass drm_plane_state Neil Armstrong
2021-10-27 10:50 ` Tomi Valkeinen
2021-10-18 14:28 ` [PATCH v6 6/9] drm/omap: Add global state as a private atomic object Neil Armstrong
2021-10-18 14:28 ` [PATCH v6 7/9] drm/omap: dynamically assign hw overlays to planes Neil Armstrong
2021-10-18 14:28 ` Neil Armstrong [this message]
2021-10-27 12:23 ` [PATCH v6 8/9] drm/omap: add plane_atomic_print_state support Tomi Valkeinen
2021-10-27 12:46 ` Neil Armstrong
2021-10-18 14:28 ` [PATCH v6 9/9] drm/omap: Add a 'right overlay' to plane state Neil Armstrong
2021-10-27 12:50 ` Tomi Valkeinen
2021-11-09 13:31 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018142842.2511200-9-narmstrong@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=bparrot@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomba@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®