From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: syzbot <syzbot+d5b23b18d2f4feae8a67@syzkaller.appspotmail.com>
Cc: bristot@redhat.com, bsegall@google.com, dietmar.eggemann@arm.com,
gor@linux.ibm.com, jgross@suse.com, juri.lelli@redhat.com,
linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@kernel.org,
mingo@redhat.com, namit@vmware.com, peterz@infradead.org,
rdunlap@infradead.org, rostedt@goodmis.org,
syzkaller-bugs@googlegroups.com, vincent.guittot@linaro.org
Subject: Re: [syzbot] possible deadlock in wake_up_all_idle_cpus
Date: Tue, 19 Oct 2021 21:08:11 +0200 [thread overview]
Message-ID: <20211019190811.ubam63tfv33c7lmx@linutronix.de> (raw)
In-Reply-To: <00000000000041567305ce80b8af@google.com>
Does this do anything useful?
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
kernel/smp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/smp.c b/kernel/smp.c
index ad0b68a3a3d36..b3bf528fa14d3 100644
--- a/kernel/smp.c
+++ b/kernel/smp.c
@@ -1170,14 +1170,14 @@ void wake_up_all_idle_cpus(void)
{
int cpu;
- cpus_read_lock();
+ migrate_disable();
for_each_online_cpu(cpu) {
if (cpu == raw_smp_processor_id())
continue;
wake_up_if_idle(cpu);
}
- cpus_read_unlock();
+ migrate_enable();
}
EXPORT_SYMBOL_GPL(wake_up_all_idle_cpus);
--
2.33.0
next prev parent reply other threads:[~2021-10-19 19:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-15 16:51 syzbot
2021-10-16 18:07 ` syzbot
2021-10-16 23:32 ` syzbot
2021-10-19 19:08 ` Sebastian Andrzej Siewior [this message]
2021-10-19 20:27 ` Peter Zijlstra
2021-10-20 6:32 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211019190811.ubam63tfv33c7lmx@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=gor@linux.ibm.com \
--cc=jgross@suse.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=syzbot+d5b23b18d2f4feae8a67@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®