From: Lin Feng <linf@wangsu.com>
To: colyli@suse.de, kent.overstreet@gmail.com
Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
linf@wangsu.com
Subject: [PATCH] bcache: use pr_err instead of pr_notice if we are really error
Date: Wed, 20 Oct 2021 10:13:13 +0800 [thread overview]
Message-ID: <20211020021313.140414-1-linf@wangsu.com> (raw)
In bcache we have:
./bset.c: pr_notice("loop %u, %llu per us\n", size,
./super.c: pr_notice("error %s: %s\n", dc->backing_dev_name, err);
./super.c: pr_notice("invalidating existing data\n");
./super.c: pr_notice("error %s: %s\n", ca->cache_dev_name, err);
./super.c: pr_notice("error %s: %s\n", ca->cache_dev_name, err);
./super.c: pr_notice("Timeout waiting for devices to be closed\n");
and 3 sites with string 'error' are really error happening on device
register.
Signed-off-by: Lin Feng <linf@wangsu.com>
---
drivers/md/bcache/super.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index f2874c77ff79..18a2e4bea9c2 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -1493,7 +1493,7 @@ static int register_bdev(struct cache_sb *sb, struct cache_sb_disk *sb_disk,
return 0;
err:
- pr_notice("error %s: %s\n", dc->backing_dev_name, err);
+ pr_err("%s: %s\n", dc->backing_dev_name, err);
bcache_device_stop(&dc->disk);
return ret;
}
@@ -2338,7 +2338,7 @@ static int cache_alloc(struct cache *ca)
err_free:
module_put(THIS_MODULE);
if (err)
- pr_notice("error %s: %s\n", ca->cache_dev_name, err);
+ pr_err("%s: %s\n", ca->cache_dev_name, err);
return ret;
}
@@ -2397,7 +2397,7 @@ static int register_cache(struct cache_sb *sb, struct cache_sb_disk *sb_disk,
err:
if (err)
- pr_notice("error %s: %s\n", ca->cache_dev_name, err);
+ pr_err("%s: %s\n", ca->cache_dev_name, err);
return ret;
}
--
2.31.1
next reply other threads:[~2021-10-20 2:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 2:13 Lin Feng [this message]
2021-10-20 15:28 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020021313.140414-1-linf@wangsu.com \
--to=linf@wangsu.com \
--cc=colyli@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®