From: Steven Rostedt <rostedt@goodmis.org>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: surenb@google.com, hridya@google.com, namhyung@kernel.org,
kernel-team@android.com, Jonathan Corbet <corbet@lwn.net>,
Ingo Molnar <mingo@redhat.com>, Shuah Khan <shuah@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Tom Zanussi <zanussi@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 3/5] tracing: Fix operator precedence for hist triggers expression
Date: Wed, 20 Oct 2021 10:28:07 -0400 [thread overview]
Message-ID: <20211020102807.0b07bc81@gandalf.local.home> (raw)
In-Reply-To: <20211020013153.4106001-4-kaleshsingh@google.com>
On Tue, 19 Oct 2021 18:31:40 -0700
Kalesh Singh <kaleshsingh@google.com> wrote:
> + minus_op = strrchr(str, '-');
> + if (minus_op) {
> + /* Unfortunately, the modifier ".sym-offset" can confuse things. */
> + if (minus_op - str >= 4 && !strncmp(minus_op - 4, ".sym-offset", 11))
> + goto out;
>
I was thinking about this, and perhaps we can add this later, but we could
just replace all ".sym-offset" with ".symXoffset" after receiving it from
the user. Then it won't be an issue during prasing.
-- Steve
next prev parent reply other threads:[~2021-10-20 14:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 1:31 [PATCH v2 0/5] tracing: Extend histogram triggers expression parsing Kalesh Singh
2021-10-20 1:31 ` [PATCH v2 1/5] tracing: Add support for creating hist trigger variables from literal Kalesh Singh
2021-10-20 15:32 ` Steven Rostedt
2021-10-20 15:55 ` Kalesh Singh
2021-10-20 15:59 ` Steven Rostedt
2021-10-20 1:31 ` [PATCH v2 2/5] tracing: Add division and multiplication support for hist triggers Kalesh Singh
2021-10-20 2:27 ` Steven Rostedt
2021-10-20 14:54 ` Kalesh Singh
2021-10-20 15:13 ` Steven Rostedt
2021-10-20 15:23 ` Kalesh Singh
2021-10-20 1:31 ` [PATCH v2 3/5] tracing: Fix operator precedence for hist triggers expression Kalesh Singh
2021-10-20 14:28 ` Steven Rostedt [this message]
2021-10-20 15:06 ` Kalesh Singh
2021-10-20 15:13 ` Steven Rostedt
2021-10-20 15:48 ` Steven Rostedt
2021-10-20 16:11 ` Kalesh Singh
2021-10-20 16:19 ` Steven Rostedt
2021-10-20 16:22 ` Kalesh Singh
2021-10-20 1:31 ` [PATCH v2 4/5] tracing/selftests: Add tests for hist trigger expression parsing Kalesh Singh
2021-10-20 1:31 ` [PATCH v2 5/5] tracing/histogram: Document expression arithmetic and constants Kalesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020102807.0b07bc81@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=corbet@lwn.net \
--cc=hridya@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®