mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco.dolcini@toradex.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Francesco Dolcini <francesco.dolcini@toradex.com>,
	linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, u.kleine-koenig@pengutronix.de,
	Stefan Agner <stefan@agner.ch>
Subject: [PATCH v2 0/2] serial: imx: fix unregister/register console
Date: Wed, 20 Oct 2021 21:26:41 +0200	[thread overview]
Message-ID: <20211020192643.476895-1-francesco.dolcini@toradex.com> (raw)

Hi,
here a couple of fixes to properly handle imx serial console
unregister/register at runtime.

The patch from Stefan was already posted years ago but never merged [1],
however is still valid and it's pretty easy to trigger the problem. We have
this patch in our kernel tree since 3 years, but for some reason we never
managed to upstream it.

As correctly wrote by Uwe [2] this issue affects multiple drivers, I could
provide a patch for those, but I will not have any way to test it.

The second patch is required to have a balanced clock enable/disable
when doing console register/unregister.

The issue is present at least since
a3cb39d258ef ("serial: core: Allow detach and attach serial device for console")

[1] https://marc.info/?l=linux-serial&m=154221779312036&w=2
[2] https://lore.kernel.org/all/20211014081028.xafpuzrxk3jvv5qn@pengutronix.de/

Changes in v2:
  Improved commit message and added fixes tag.
 
---

Francesco Dolcini (1):
  serial: imx: disable console clocks on unregister

Stefan Agner (1):
  serial: imx: fix detach/attach of serial console

 drivers/tty/serial/imx.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

-- 
2.25.1


             reply	other threads:[~2021-10-20 19:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 19:26 Francesco Dolcini [this message]
2021-10-20 19:26 ` [PATCH v2 1/2] serial: imx: fix detach/attach of serial console Francesco Dolcini
2021-10-20 19:39   ` Uwe Kleine-König
2021-10-20 19:54   ` Andy Shevchenko
2021-10-21  8:28     ` Greg Kroah-Hartman
2021-10-20 19:26 ` [PATCH v2 2/2] serial: imx: disable console clocks on unregister Francesco Dolcini
2021-10-21  8:39   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211020192643.476895-1-francesco.dolcini@toradex.com \
    --to=francesco.dolcini@toradex.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®