mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Jan Kiszka" <jan.kiszka@siemens.com>,
	"Mantas Mikulėnas" <grawity@gmail.com>,
	"Javier S . Pedro" <debbugs@javispedro.com>
Subject: Re: [PATCH] Revert "watchdog: iTCO_wdt: Account for rebooting on second timeout"
Date: Wed, 20 Oct 2021 12:44:08 -0700	[thread overview]
Message-ID: <20211020194408.GA2882870@roeck-us.net> (raw)
In-Reply-To: <20211008003302.1461733-1-linux@roeck-us.net>

Wim,

On Thu, Oct 07, 2021 at 05:33:02PM -0700, Guenter Roeck wrote:
> This reverts commit cb011044e34c ("watchdog: iTCO_wdt: Account for
> rebooting on second timeout") and commit aec42642d91f ("watchdog: iTCO_wdt:
> Fix detection of SMI-off case") since those patches cause a regression
> on certain boards (https://bugzilla.kernel.org/show_bug.cgi?id=213809).
> 
> While this revert may result in some boards to only reset after twice
> the configured timeout value, that is still better than a watchdog reset
> after half the configured value.
> 
> Fixes: cb011044e34c ("watchdog: iTCO_wdt: Account for rebooting on second timeout")
> Fixes: aec42642d91f ("watchdog: iTCO_wdt: Fix detection of SMI-off case")
> Cc: Jan Kiszka <jan.kiszka@siemens.com>
> Cc: Mantas Mikulėnas <grawity@gmail.com>
> Reported-by: Javier S. Pedro <debbugs@javispedro.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Any chance you can send a pull request with this patch prior to the v5.15
release ?

Thanks,
Guenter

  parent reply	other threads:[~2021-10-20 19:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08  0:33 Guenter Roeck
2021-10-08  7:52 ` Jan Kiszka
2021-10-08 13:05   ` Guenter Roeck
2021-10-20 19:44 ` Guenter Roeck [this message]
2021-10-26 15:40   ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211020194408.GA2882870@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=debbugs@javispedro.com \
    --cc=grawity@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®