From: Martin Habets <habetsm.xilinx@gmail.com>
To: Erik Ekman <erik@kryo.se>
Cc: Edward Cree <ecree.xilinx@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sfc: Don't use netif_info before net_device setup
Date: Thu, 21 Oct 2021 11:07:01 +0100 [thread overview]
Message-ID: <20211021100701.k2dzn7mn5exyofkm@gmail.com> (raw)
In-Reply-To: <20211019224016.26530-1-erik@kryo.se>
On Wed, Oct 20, 2021 at 12:40:16AM +0200, Erik Ekman wrote:
> Use pci_info instead to avoid unnamed/uninitialized noise:
>
> [197088.688729] sfc 0000:01:00.0: Solarflare NIC detected
> [197088.690333] sfc 0000:01:00.0: Part Number : SFN5122F
> [197088.729061] sfc 0000:01:00.0 (unnamed net_device) (uninitialized): no SR-IOV VFs probed
> [197088.729071] sfc 0000:01:00.0 (unnamed net_device) (uninitialized): no PTP support
>
> Inspired by fa44821a4ddd ("sfc: don't use netif_info et al before
> net_device is registered") from Heiner Kallweit.
>
> Signed-off-by: Erik Ekman <erik@kryo.se>
Acked-by: Martin Habets <habetsm.xilinx@gmail.com>
> ---
> drivers/net/ethernet/sfc/ptp.c | 4 ++--
> drivers/net/ethernet/sfc/siena_sriov.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
> index a39c5143b386..797e51802ccb 100644
> --- a/drivers/net/ethernet/sfc/ptp.c
> +++ b/drivers/net/ethernet/sfc/ptp.c
> @@ -648,7 +648,7 @@ static int efx_ptp_get_attributes(struct efx_nic *efx)
> } else if (rc == -EINVAL) {
> fmt = MC_CMD_PTP_OUT_GET_ATTRIBUTES_SECONDS_NANOSECONDS;
> } else if (rc == -EPERM) {
> - netif_info(efx, probe, efx->net_dev, "no PTP support\n");
> + pci_info(efx->pci_dev, "no PTP support\n");
> return rc;
> } else {
> efx_mcdi_display_error(efx, MC_CMD_PTP, sizeof(inbuf),
> @@ -824,7 +824,7 @@ static int efx_ptp_disable(struct efx_nic *efx)
> * should only have been called during probe.
> */
> if (rc == -ENOSYS || rc == -EPERM)
> - netif_info(efx, probe, efx->net_dev, "no PTP support\n");
> + pci_info(efx->pci_dev, "no PTP support\n");
> else if (rc)
> efx_mcdi_display_error(efx, MC_CMD_PTP,
> MC_CMD_PTP_IN_DISABLE_LEN,
> diff --git a/drivers/net/ethernet/sfc/siena_sriov.c b/drivers/net/ethernet/sfc/siena_sriov.c
> index 83dcfcae3d4b..441e7f3e5375 100644
> --- a/drivers/net/ethernet/sfc/siena_sriov.c
> +++ b/drivers/net/ethernet/sfc/siena_sriov.c
> @@ -1057,7 +1057,7 @@ void efx_siena_sriov_probe(struct efx_nic *efx)
> return;
>
> if (efx_siena_sriov_cmd(efx, false, &efx->vi_scale, &count)) {
> - netif_info(efx, probe, efx->net_dev, "no SR-IOV VFs probed\n");
> + pci_info(efx->pci_dev, "no SR-IOV VFs probed\n");
> return;
> }
> if (count > 0 && count > max_vfs)
> --
> 2.31.1
next prev parent reply other threads:[~2021-10-21 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 22:40 Erik Ekman
2021-10-21 10:07 ` Martin Habets [this message]
2021-10-21 23:33 ` Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021100701.k2dzn7mn5exyofkm@gmail.com \
--to=habetsm.xilinx@gmail.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=erik@kryo.se \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome