mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dario Binacchi <dariobin@libero.it>
To: linux-kernel@vger.kernel.org
Cc: Dario Binacchi <dariobin@libero.it>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rachna Patil <rachna@ti.com>,
	linux-input@vger.kernel.org
Subject: [PATCH 1/6] input: ti_am335x_tsc: set ADCREFM for X configuration
Date: Sun, 24 Oct 2021 16:59:25 +0200	[thread overview]
Message-ID: <20211024145931.1916-2-dariobin@libero.it> (raw)
In-Reply-To: <20211024145931.1916-1-dariobin@libero.it>

As reported by the STEPCONFIG[1-16] registered field descriptions of the
TI reference manual, for the ADC "in single ended, SEL_INM_SWC_3_0 must
be 1xxx".

Unlike the Y and Z coordinates, this bit has not been set for the step
configuration registers used to sample the X coordinate.

Fixes: 1b8be32e691 ("Input: add support for TI Touchscreen controller")
Signed-off-by: Dario Binacchi <dariobin@libero.it>
---

 drivers/input/touchscreen/ti_am335x_tsc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
index 83e685557a19..fd3ffdd23470 100644
--- a/drivers/input/touchscreen/ti_am335x_tsc.c
+++ b/drivers/input/touchscreen/ti_am335x_tsc.c
@@ -131,7 +131,8 @@ static void titsc_step_config(struct titsc *ts_dev)
 	u32 stepenable;
 
 	config = STEPCONFIG_MODE_HWSYNC |
-			STEPCONFIG_AVG_16 | ts_dev->bit_xp;
+			STEPCONFIG_AVG_16 | ts_dev->bit_xp |
+			STEPCONFIG_INM_ADCREFM;
 	switch (ts_dev->wires) {
 	case 4:
 		config |= STEPCONFIG_INP(ts_dev->inp_yp) | ts_dev->bit_xn;
-- 
2.17.1


  reply	other threads:[~2021-10-24 15:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-24 14:59 [PATCH 0/6] input: touchscreen: am335x: fix and improvements Dario Binacchi
2021-10-24 14:59 ` Dario Binacchi [this message]
2021-10-24 14:59 ` [PATCH 2/6] input: ti_am335x_tsc: fix STEPCONFIG setup for Z2 Dario Binacchi
2021-10-24 14:59 ` [PATCH 3/6] input: ti_am335x_tsc: lower the X and Y sampling time Dario Binacchi
2021-10-24 14:59 ` [PATCH 4/6] dt-bindings: input: ti-tsc-adc: fix tsc node example Dario Binacchi
2021-10-29  2:13   ` Rob Herring
2021-10-24 14:59 ` [PATCH 5/6] mfd: ti_am335x_tscadc: fix reading a tsc property from DT Dario Binacchi
2021-10-24 14:59 ` [PATCH 6/6] mfd: ti_am335x_tscadc: drop the CNTRLREG_8WIRE macro Dario Binacchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211024145931.1916-2-dariobin@libero.it \
    --to=dariobin@libero.it \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rachna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®