From: Brad Larson <brad@pensando.io>
To: linux-arm-kernel@lists.infradead.org
Cc: arnd@arndb.de, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, broonie@kernel.org,
fancer.lancer@gmail.com, adrian.hunter@intel.com,
ulf.hansson@linaro.org, olof@lixom.net, brad@pensando.io,
linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 08/11] spi: cadence-quadspi: Add compatible for Pensando Elba SoC
Date: Sun, 24 Oct 2021 18:51:53 -0700 [thread overview]
Message-ID: <20211025015156.33133-9-brad@pensando.io> (raw)
In-Reply-To: <20211025015156.33133-1-brad@pensando.io>
The Pensando Elba SoC has the Cadence QSPI controller integrated.
The quirk CQSPI_NEEDS_APB_AHB_HAZARD_WAR is added and if enabled
a dummy readback from the controller is performed to ensure
synchronization.
Signed-off-by: Brad Larson <brad@pensando.io>
---
drivers/spi/spi-cadence-quadspi.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-quadspi.c
index 101cc71bffa7..af36514250d2 100644
--- a/drivers/spi/spi-cadence-quadspi.c
+++ b/drivers/spi/spi-cadence-quadspi.c
@@ -35,6 +35,7 @@
/* Quirks */
#define CQSPI_NEEDS_WR_DELAY BIT(0)
#define CQSPI_DISABLE_DAC_MODE BIT(1)
+#define CQSPI_NEEDS_APB_AHB_HAZARD_WAR BIT(2)
/* Capabilities */
#define CQSPI_SUPPORTS_OCTAL BIT(0)
@@ -74,6 +75,7 @@ struct cqspi_st {
int current_cs;
unsigned long master_ref_clk_hz;
bool is_decoded_cs;
+ bool apb_ahb_hazard;
u32 fifo_depth;
u32 fifo_width;
u32 num_chipselect;
@@ -862,6 +864,13 @@ static int cqspi_indirect_write_execute(struct cqspi_flash_pdata *f_pdata,
if (cqspi->wr_delay)
ndelay(cqspi->wr_delay);
+ /*
+ * If a hazard exists between the APB and AHB interfaces, perform a
+ * dummy readback from the controller to ensure synchronization.
+ */
+ if (cqspi->apb_ahb_hazard)
+ (void)readl(reg_base + CQSPI_REG_INDIRECTWR);
+
while (remaining > 0) {
size_t write_words, mod_bytes;
@@ -1548,6 +1557,8 @@ static int cqspi_probe(struct platform_device *pdev)
master->mode_bits |= SPI_RX_OCTAL | SPI_TX_OCTAL;
if (!(ddata->quirks & CQSPI_DISABLE_DAC_MODE))
cqspi->use_direct_mode = true;
+ if (ddata->quirks & CQSPI_NEEDS_APB_AHB_HAZARD_WAR)
+ cqspi->apb_ahb_hazard = true;
}
ret = devm_request_irq(dev, irq, cqspi_irq_handler, 0,
@@ -1656,6 +1667,10 @@ static const struct cqspi_driver_platdata intel_lgm_qspi = {
.quirks = CQSPI_DISABLE_DAC_MODE,
};
+static const struct cqspi_driver_platdata pen_cdns_qspi = {
+ .quirks = CQSPI_NEEDS_APB_AHB_HAZARD_WAR | CQSPI_DISABLE_DAC_MODE,
+};
+
static const struct of_device_id cqspi_dt_ids[] = {
{
.compatible = "cdns,qspi-nor",
@@ -1673,6 +1688,10 @@ static const struct of_device_id cqspi_dt_ids[] = {
.compatible = "intel,lgm-qspi",
.data = &intel_lgm_qspi,
},
+ {
+ .compatible = "pensando,elba-qspi",
+ .data = &pen_cdns_qspi,
+ },
{ /* end of table */ }
};
--
2.17.1
next prev parent reply other threads:[~2021-10-25 1:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 1:51 [PATCH v3 00/11] Support " Brad Larson
2021-10-25 1:51 ` [PATCH v3 01/11] dt-bindings: arm: pensando: add Pensando boards Brad Larson
2021-10-27 21:37 ` Rob Herring
2021-10-25 1:51 ` [PATCH v3 02/11] dt-bindings: Add vendor prefix for Pensando Systems Brad Larson
2021-10-27 21:38 ` Rob Herring
2021-11-05 0:16 ` Brad Larson
2021-10-25 1:51 ` [PATCH v3 03/11] dt-bindings: mmc: Add Pensando Elba SoC binding Brad Larson
2021-10-25 12:54 ` Rob Herring
2021-11-05 0:13 ` Brad Larson
2021-10-26 18:10 ` Rob Herring
2021-11-17 1:21 ` Brad Larson
2021-11-17 1:27 ` Brad Larson
2021-10-25 1:51 ` [PATCH v3 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC Brad Larson
2021-10-27 21:38 ` Rob Herring
2021-10-28 7:26 ` Serge Semin
2021-11-15 22:05 ` Brad Larson
2021-10-25 1:51 ` [PATCH v3 05/11] spi: dw: Add Pensando Elba SoC SPI Controller bindings Brad Larson
2021-10-27 21:42 ` Rob Herring
2021-10-28 7:49 ` Serge Semin
2021-10-28 7:52 ` Serge Semin
2021-11-15 22:24 ` Brad Larson
2021-11-16 11:29 ` Serge Semin
2021-11-16 23:11 ` Brad Larson
2021-11-17 8:19 ` Serge Semin
2021-11-17 21:35 ` Brad Larson
2021-10-25 1:51 ` [PATCH v3 06/11] MAINTAINERS: Add entry for PENSANDO Brad Larson
2021-10-25 1:51 ` [PATCH v3 07/11] arm64: Add config for Pensando SoC platforms Brad Larson
2021-10-25 1:51 ` Brad Larson [this message]
2021-10-25 1:51 ` [PATCH v3 09/11] mmc: sdhci-cadence: Add Pensando Elba SoC support Brad Larson
2021-10-25 1:51 ` [PATCH v3 10/11] spi: dw: Add support for Pensando Elba SoC Brad Larson
2021-10-28 9:11 ` Serge Semin
2021-10-31 13:19 ` Andy Shevchenko
2021-10-25 1:51 ` [PATCH v3 11/11] arm64: dts: Add Pensando Elba SoC support Brad Larson
2021-10-25 9:17 ` Mark Rutland
2021-10-25 11:15 ` Marc Zyngier
2021-11-05 0:02 ` Brad Larson
2021-11-05 11:35 ` Marc Zyngier
2021-11-08 19:35 ` Brad Larson
2021-11-08 19:53 ` Marc Zyngier
2021-11-08 20:01 ` Brad Larson
2021-11-04 22:53 ` Brad Larson
2021-11-08 10:25 ` Mark Rutland
2021-11-08 19:02 ` Brad Larson
2021-10-27 21:37 ` Rob Herring
2021-11-11 2:08 ` Brad Larson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025015156.33133-9-brad@pensando.io \
--to=brad@pensando.io \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®