From: Steffen Klassert <steffen.klassert@secunet.com>
To: luo penghao <cgel.zte@gmail.com>
Cc: SimonHorman <horms@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"luo penghao" <luo.penghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH linux-next] xfrm: Remove redundant fields and related parentheses
Date: Mon, 25 Oct 2021 10:20:45 +0200 [thread overview]
Message-ID: <20211025082045.GC36125@gauss3.secunet.de> (raw)
In-Reply-To: <20211022095911.1066475-1-luo.penghao@zte.com.cn>
On Fri, Oct 22, 2021 at 09:59:11AM +0000, luo penghao wrote:
> The variable err is not necessary in such places. It should be revmoved
> for the simplicity of the code. This will cause the double parentheses
> to be redundant, and the inner parentheses should be deleted.
>
> The clang_analyzer complains as follows:
>
> net/xfrm/xfrm_input.c:533: warning:
> net/xfrm/xfrm_input.c:563: warning:
>
> Although the value stored to 'err' is used in the enclosing expression,
> the value is never actually read from 'err'.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: luo penghao <luo.penghao@zte.com.cn>
Is this an update to your previous patch?
If so, please mark it as such with a 'v2'
and describe what changed.
Thanks!
prev parent reply other threads:[~2021-10-25 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 9:59 luo penghao
2021-10-25 8:20 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025082045.GC36125@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=cgel.zte@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luo.penghao@zte.com.cn \
--cc=netdev@vger.kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®