From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE12C433F5 for ; Mon, 25 Oct 2021 17:00:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D97D060FBF for ; Mon, 25 Oct 2021 17:00:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234305AbhJYRCl (ORCPT ); Mon, 25 Oct 2021 13:02:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:54904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234257AbhJYRC2 (ORCPT ); Mon, 25 Oct 2021 13:02:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BB9FB60FE8; Mon, 25 Oct 2021 17:00:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635181205; bh=zymw0Cd5SrCynRtyeFd4YXZw31nviPLgRFKiy/lGjyw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kGusySnBrcEH1kClVP8c9Al/x4OWy6Yj2GX9+EKYK4myG7l8qfr2dg3yb195B0b+k QGgJcKVdGzh4lfeZ7sBBds10E/xnR9NzIBuG7ejj+Pdpu3GumEsX9/UMJIugr7HTfD tmV9OSAWlhSQPv1bV7x+z0KRxC58/KIfeVa3CweGTD/b+VJPUq9SNknFr3MLDc/t4y KwMkSuYeTJWwM4JEZGg+Lh0xjx0sBnTw3Kp7F5mWoALoWSLnObZLj4SVjONCUmEzqz weRILJCruY9Tr4KepVmVRfUI0kL9PqSYTuXeCx9yA+luF+raKFlZrQ3cUb65Qimfre qRKWT3Z9WVYUA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zheyu Ma , "David S . Miller" , Sasha Levin , sgoutham@marvell.com, kuba@kernel.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.14 09/18] cavium: Return negative value when pci_alloc_irq_vectors() fails Date: Mon, 25 Oct 2021 12:59:22 -0400 Message-Id: <20211025165939.1393655-9-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211025165939.1393655-1-sashal@kernel.org> References: <20211025165939.1393655-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zheyu Ma [ Upstream commit b2cddb44bddc1a9c5949a978bb454bba863264db ] During the process of driver probing, the probe function should return < 0 for failure, otherwise, the kernel will treat value > 0 as success. Signed-off-by: Zheyu Ma Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c b/drivers/net/ethernet/cavium/thunder/nic_main.c index 9361f964bb9b..816453a4f8d6 100644 --- a/drivers/net/ethernet/cavium/thunder/nic_main.c +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c @@ -1193,7 +1193,7 @@ static int nic_register_interrupts(struct nicpf *nic) dev_err(&nic->pdev->dev, "Request for #%d msix vectors failed, returned %d\n", nic->num_vec, ret); - return 1; + return ret; } /* Register mailbox interrupt handler */ -- 2.33.0