From: Ioannis Angelakopoulos <iangelak@redhat.com>
To: linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com,
linux-kernel@vger.kernel.org, jack@suse.cz, amir73il@gmail.com,
viro@zeniv.linux.org.uk, miklos@szeredi.hu, vgoyal@redhat.com
Cc: Ioannis Angelakopoulos <iangelak@redhat.com>
Subject: [RFC PATCH 2/7] FUSE: Add the remote inotify support capability to FUSE
Date: Mon, 25 Oct 2021 16:46:29 -0400 [thread overview]
Message-ID: <20211025204634.2517-3-iangelak@redhat.com> (raw)
In-Reply-To: <20211025204634.2517-1-iangelak@redhat.com>
Add the remote inotify support capability to FUSE init flags, which is
supported by the kernel only when the "CONFIG_INOTIFY_USER" config
option is enabled in the guest kernel.
If virtiofsd wants the remote inotify support feature enabled only then
the guest kernel will enable it. However, this means that the kernel
will suppress the local inotify events related to inodes within the
directory exported through virtiofs. The suppression of local events
prevents the guest from receiving duplicate events; one from the guest
kernel and one from virtiofsd.
Signed-off-by: Ioannis Angelakopoulos <iangelak@redhat.com>
---
fs/fuse/fuse_i.h | 7 +++++++
fs/fuse/inode.c | 6 ++++++
2 files changed, 13 insertions(+)
diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h
index f55f9f94b1a4..c3cebfb936d2 100644
--- a/fs/fuse/fuse_i.h
+++ b/fs/fuse/fuse_i.h
@@ -649,6 +649,13 @@ struct fuse_conn {
*/
unsigned handle_killpriv_v2:1;
+ /* Is the remote inotify capability supported by the filesystem?
+ * If yes then all the local inotify events related to inodes
+ * in the FUSE filesystem will be suppressed and only the remote
+ * events will be let through.
+ */
+ unsigned no_fsnotify:1;
+
/*
* The following bitfields are only for optimization purposes
* and hence races in setting them will not cause malfunction
diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index 12d49a1914e8..039a040ddc91 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -1143,6 +1143,9 @@ static void process_init_reply(struct fuse_mount *fm, struct fuse_args *args,
}
if (arg->flags & FUSE_SETXATTR_EXT)
fc->setxattr_ext = 1;
+ if (!(arg->flags & FUSE_HAVE_FSNOTIFY)) {
+ fc->no_fsnotify = 1;
+ }
} else {
ra_pages = fc->max_read / PAGE_SIZE;
fc->no_lock = 1;
@@ -1190,6 +1193,9 @@ void fuse_send_init(struct fuse_mount *fm)
#ifdef CONFIG_FUSE_DAX
if (fm->fc->dax)
ia->in.flags |= FUSE_MAP_ALIGNMENT;
+#endif
+#ifdef CONFIG_INOTIFY_USER
+ ia->in.flags |= FUSE_HAVE_FSNOTIFY;
#endif
if (fm->fc->auto_submounts)
ia->in.flags |= FUSE_SUBMOUNTS;
--
2.33.0
next prev parent reply other threads:[~2021-10-25 20:47 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 20:46 [RFC PATCH 0/7] Inotify support in FUSE and virtiofs Ioannis Angelakopoulos
2021-10-25 20:46 ` [RFC PATCH 1/7] FUSE: Add the fsnotify opcode and in/out structs to FUSE Ioannis Angelakopoulos
2021-10-26 14:56 ` Amir Goldstein
2021-10-26 18:28 ` Amir Goldstein
[not found] ` <CAO17o20+jiij64y7b3eKoCjG5b_mLZj6o1LSnZ7+8exN3dFYEg@mail.gmail.com>
2021-10-27 5:46 ` Amir Goldstein
2021-10-27 21:46 ` Vivek Goyal
2021-10-28 4:13 ` Amir Goldstein
2021-10-28 14:20 ` Vivek Goyal
2021-10-25 20:46 ` Ioannis Angelakopoulos [this message]
2021-10-25 20:46 ` [RFC PATCH 3/7] FUSE,Inotify,Fsnotify,VFS: Add the fuse_fsnotify_update_mark inode operation Ioannis Angelakopoulos
2021-10-26 15:06 ` Amir Goldstein
2021-11-01 17:49 ` Vivek Goyal
2021-11-02 7:34 ` Amir Goldstein
2021-10-25 20:46 ` [RFC PATCH 4/7] FUSE: Add the fuse_fsnotify_send_request to FUSE Ioannis Angelakopoulos
2021-10-25 20:46 ` [RFC PATCH 5/7] Fsnotify: Add a wrapper around the fsnotify function Ioannis Angelakopoulos
2021-10-26 14:37 ` Amir Goldstein
2021-10-26 15:38 ` Vivek Goyal
2021-10-25 20:46 ` [RFC PATCH 6/7] FUSE,Fsnotify: Add the fuse_fsnotify_event inode operation Ioannis Angelakopoulos
2021-10-25 20:46 ` [RFC PATCH 7/7] virtiofs: Add support for handling the remote fsnotify notifications Ioannis Angelakopoulos
2021-10-26 15:23 ` [RFC PATCH 0/7] Inotify support in FUSE and virtiofs Amir Goldstein
2021-10-26 15:52 ` Vivek Goyal
2021-10-26 18:19 ` Amir Goldstein
2021-10-26 16:18 ` Vivek Goyal
2021-10-26 17:59 ` Amir Goldstein
2021-10-26 18:27 ` Vivek Goyal
2021-10-26 19:04 ` Amir Goldstein
[not found] ` <CAO17o20sdKAWQN6w7Oe0Ze06qcK+J=6rrmA_aWGnY__MRVDCKw@mail.gmail.com>
2021-10-27 5:59 ` Amir Goldstein
2021-10-27 13:23 ` Jan Kara
2021-10-27 20:29 ` Vivek Goyal
2021-10-27 20:37 ` Vivek Goyal
2021-11-02 11:09 ` Jan Kara
2021-11-02 12:54 ` Amir Goldstein
2021-11-02 20:34 ` Vivek Goyal
2021-11-03 7:31 ` Amir Goldstein
2021-11-03 22:29 ` Vivek Goyal
2021-11-04 5:19 ` Amir Goldstein
2021-11-03 10:09 ` Jan Kara
2021-11-03 11:17 ` Amir Goldstein
2021-11-03 22:36 ` Vivek Goyal
2021-11-04 5:29 ` Amir Goldstein
2021-11-04 10:03 ` Jan Kara
2021-11-05 14:30 ` Vivek Goyal
2021-11-10 6:28 ` Amir Goldstein
2021-11-11 17:30 ` Jan Kara
2021-11-11 20:52 ` Amir Goldstein
2021-10-27 20:24 ` Vivek Goyal
2021-10-28 5:11 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025204634.2517-3-iangelak@redhat.com \
--to=iangelak@redhat.com \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=vgoyal@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®