From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18E27C433EF for ; Wed, 27 Oct 2021 13:23:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC742610A4 for ; Wed, 27 Oct 2021 13:23:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242113AbhJ0NZv (ORCPT ); Wed, 27 Oct 2021 09:25:51 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:51818 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbhJ0NZq (ORCPT ); Wed, 27 Oct 2021 09:25:46 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 35D921FD4E; Wed, 27 Oct 2021 13:23:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1635341000; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o/3Nbz49/kyQ2NEUZpXzOGtQ57B0/FoxfakRAxW6Cek=; b=z79qK7ImJM9M3P0lN+P+TvwlZtk/o3DnybsO7hyOOwmdvvs41paBEdtSP+NcYUyqE3corR e5s66EYhw4IhKabsTDEkW4lAysMXPQAYeIZJSPNDqc7GaobU7fbuXbU8XMYZMIcXHshdQW 2ESKiKGRFCf01Upmi5QTCEdMA+5Ffi4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1635341000; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o/3Nbz49/kyQ2NEUZpXzOGtQ57B0/FoxfakRAxW6Cek=; b=XOERzLFZuhMxAo6qingMdKXRnYFUzy5dEBlNzYCVL2lwyjpZ/6xK3aOigRB07UPV0m6J9m sCm+X2hCwUcJy2Cw== Received: from quack2.suse.cz (unknown [10.100.224.230]) by relay2.suse.de (Postfix) with ESMTP id 1AEA4A3B89; Wed, 27 Oct 2021 13:23:20 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id ED2271F2C66; Wed, 27 Oct 2021 15:23:19 +0200 (CEST) Date: Wed, 27 Oct 2021 15:23:19 +0200 From: Jan Kara To: Amir Goldstein Cc: Ioannis Angelakopoulos , Vivek Goyal , linux-fsdevel , virtio-fs-list , linux-kernel , Jan Kara , Al Viro , Miklos Szeredi , Steve French Subject: Re: [RFC PATCH 0/7] Inotify support in FUSE and virtiofs Message-ID: <20211027132319.GA7873@quack2.suse.cz> References: <20211025204634.2517-1-iangelak@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 27-10-21 08:59:15, Amir Goldstein wrote: > On Tue, Oct 26, 2021 at 10:14 PM Ioannis Angelakopoulos > wrote: > > On Tue, Oct 26, 2021 at 2:27 PM Vivek Goyal wrote: > > The problem here is that the OPEN event might still be travelling towards the guest in the > > virtqueues and arrives after the guest has already deleted its local inode. > > While the remote event (OPEN) received by the guest is valid, its fsnotify > > subsystem will drop it since the local inode is not there. > > > > I have a feeling that we are mixing issues related to shared server > and remote fsnotify. I don't think Ioannis was speaking about shared server case here. I think he says that in a simple FUSE remote notification setup we can loose OPEN events (or basically any other) if the inode for which the event happens gets deleted sufficiently early after the event being generated. That seems indeed somewhat unexpected and could be confusing if it happens e.g. for some directory operations. Honza -- Jan Kara SUSE Labs, CR