From: Steven Rostedt <rostedt@goodmis.org>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
surenb@google.com, hridya@google.com, namhyung@kernel.org,
kernel-team@android.com, Ingo Molnar <mingo@redhat.com>,
Shuah Khan <shuah@kernel.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/3] tracing/kselftests: Remove triggers with references before their definitions
Date: Wed, 27 Oct 2021 19:54:54 -0400 [thread overview]
Message-ID: <20211027195454.60993c83@rorschach.local.home> (raw)
In-Reply-To: <CAC_TJvdxEuqkzH+VDNQvWZbLjHj0BKfnCHn647Y9-Ve2UTftRg@mail.gmail.com>
On Wed, 27 Oct 2021 16:26:00 -0700
Kalesh Singh <kaleshsingh@google.com> wrote:
> > Why don't you use 'tac'? I love that idea :)
> > Did you find any issue?
>
> Hi Masami,
>
> Thanks for the reviews. As with the first set of patches using tac
> gives a regression here, though I'm not sure why it doesn't work -- I
> also thought reversing the order would handle any dependencies
> correctly.
Right, because are triggers not added by list_add_rcu() which adds to
the head of the list. If anything, shouldn't things be removed in order?
-- Steve
next prev parent reply other threads:[~2021-10-27 23:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 20:59 [PATCH 0/3] tracing/kselftest: histogram trigger expression tests Kalesh Singh
2021-10-27 20:59 ` [PATCH 1/3] tracing/histogram: Document hist trigger variables Kalesh Singh
2021-10-27 22:13 ` Masami Hiramatsu
2021-10-27 20:59 ` [PATCH 2/3] tracing/kselftests: Remove triggers with references before their definitions Kalesh Singh
2021-10-27 21:58 ` Masami Hiramatsu
2021-10-27 23:26 ` Kalesh Singh
2021-10-27 23:54 ` Steven Rostedt [this message]
2021-10-28 0:43 ` Masami Hiramatsu
2021-10-28 2:58 ` Kalesh Singh
2021-10-28 17:10 ` Kalesh Singh
2021-10-27 20:59 ` [PATCH v5 3/3] tracing/selftests: Add tests for hist trigger expression parsing Kalesh Singh
2021-10-27 22:12 ` Masami Hiramatsu
2021-10-27 21:04 ` [PATCH 0/3] tracing/kselftest: histogram trigger expression tests Kalesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027195454.60993c83@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=hridya@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®