From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E4EC433F5 for ; Wed, 27 Oct 2021 22:13:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB6F5610C7 for ; Wed, 27 Oct 2021 22:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbhJ0WPv (ORCPT ); Wed, 27 Oct 2021 18:15:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:49282 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230091AbhJ0WPt (ORCPT ); Wed, 27 Oct 2021 18:15:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 45FD860EFE; Wed, 27 Oct 2021 22:13:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635372803; bh=Qusou+GTSRWee2wKlxAwgNDheywqVp69l4gLDXw9uj0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DIhLgQ17rx0gtZdAOFcI636rtClyZ9Hpe4HlkQJ9q4YUkgBx89pNPBjB72Thz/KqH f9gtqZcBFR0Rvsz/n7+WudLHNo5RoBVXRdBqrvsfgO2fG9+D/fXQaKi93DQp+HKjjs ek0rxdT3K4MG3eGBS4g1DQTI2fBlsbeYD8+/FtNllj554LwxNtb5irENhGYh6lvIGo iYy0VGj7o5d5r84vGP2SV5rV1pZAVs8hPSkKf1FkjqMjXJAt5XlguMkNr2hg2j+Zgu xg1825g+bz4w17Drr3ZtlTCYfXS1AgA3cYT+jCuapVXxW0ZLMLksl+YIR6XdBXY4fX U0hJdp7kpfS9Q== Date: Thu, 28 Oct 2021 07:13:19 +0900 From: Masami Hiramatsu To: Kalesh Singh Cc: surenb@google.com, hridya@google.com, namhyung@kernel.org, kernel-team@android.com, rostedt@goodmis.org, mhiramat@kernel.org, Ingo Molnar , Shuah Khan , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH 1/3] tracing/histogram: Document hist trigger variables Message-Id: <20211028071319.44e3e885352866713dd08046@kernel.org> In-Reply-To: <20211027205919.1648553-2-kaleshsingh@google.com> References: <20211027205919.1648553-1-kaleshsingh@google.com> <20211027205919.1648553-2-kaleshsingh@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Oct 2021 13:59:08 -0700 Kalesh Singh wrote: > Update the tracefs README to describe how hist trigger variables > can be created. > > Signed-off-by: Kalesh Singh This looks good to me. Acked-by: Masami Hiramatsu Thank you! > --- > kernel/trace/trace.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index bc677cd64224..c41b3786401d 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -5628,6 +5628,7 @@ static const char readme_msg[] = > #ifdef CONFIG_HIST_TRIGGERS > " hist trigger\t- If set, event hits are aggregated into a hash table\n" > "\t Format: hist:keys=\n" > + "\t [:=[,=...]]\n" > "\t [:values=]\n" > "\t [:sort=]\n" > "\t [:size=#entries]\n" > @@ -5639,6 +5640,16 @@ static const char readme_msg[] = > "\t common_timestamp - to record current timestamp\n" > "\t common_cpu - to record the CPU the event happened on\n" > "\n" > + "\t A hist trigger variable can be:\n" > + "\t - a reference to a field e.g. x=current_timestamp,\n" > + "\t - a reference to another variable e.g. y=$x,\n" > + "\t - a numeric literal: e.g. ms_per_sec=1000,\n" > + "\t - an arithmetic expression: e.g. time_secs=current_timestamp/1000\n" > + "\n" > + "\t hist trigger aritmethic expressions support addition(+), subtraction(-),\n" > + "\t multiplication(*) and division(/) operators. An operand can be either a\n" > + "\t variable reference, field or numeric literal.\n" > + "\n" > "\t When a matching event is hit, an entry is added to a hash\n" > "\t table using the key(s) and value(s) named, and the value of a\n" > "\t sum called 'hitcount' is incremented. Keys and values\n" > -- > 2.33.0.1079.g6e70778dc9-goog > -- Masami Hiramatsu