From: Laurent Vivier <lvivier@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: amit@kernel.org, Herbert Xu <herbert@gondor.apana.org.au>,
Matt Mackall <mpm@selenic.com>,
virtualization@lists.linux-foundation.org,
Dmitriy Vyukov <dvyukov@google.com>,
rusty@rustcorp.com.au, akong@redhat.com,
Alexander Potapenko <glider@google.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
linux-crypto@vger.kernel.org, Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH v2 0/4] hwrng: virtio - add an internal buffer
Date: Thu, 28 Oct 2021 12:11:07 +0200 [thread overview]
Message-ID: <20211028101111.128049-1-lvivier@redhat.com> (raw)
hwrng core uses two buffers that can be mixed in the virtio-rng queue.
This series fixes the problem by adding an internal buffer in virtio-rng.
Once the internal buffer is added, we can fix two other problems:
- to be able to release the driver without waiting the device releases the
buffer
- actually returns some data when wait=0 as we can have some already
available data
It also tries to improve the performance by always having a buffer in
the queue of the device.
v2:
fixes issue reported by syzbot+b86736b5935e0d25b446@syzkaller.appspotmail.com
by reseting data_idx to 0 when the buffer is submitted not when it is
received as the consumer checks for data_avail, not only for the completion.
Laurent Vivier (4):
hwrng: virtio - add an internal buffer
hwrng: virtio - don't wait on cleanup
hwrng: virtio - don't waste entropy
hwrng: virtio - always add a pending request
drivers/char/hw_random/virtio-rng.c | 86 ++++++++++++++++++++++-------
1 file changed, 65 insertions(+), 21 deletions(-)
--
2.31.1
next reply other threads:[~2021-10-28 10:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 10:11 Laurent Vivier [this message]
2021-10-28 10:11 ` [PATCH v2 1/4] " Laurent Vivier
2021-10-28 10:11 ` [PATCH v2 2/4] hwrng: virtio - don't wait on cleanup Laurent Vivier
2021-10-28 10:11 ` [PATCH v2 3/4] hwrng: virtio - don't waste entropy Laurent Vivier
2021-10-28 10:11 ` [PATCH v2 4/4] hwrng: virtio - always add a pending request Laurent Vivier
2022-08-02 12:49 ` Vladimir Murzin
2022-08-03 8:57 ` Vladimir Murzin
2022-08-03 11:39 ` Michael S. Tsirkin
2022-08-03 12:25 ` Vladimir Murzin
2022-08-03 12:55 ` Michael S. Tsirkin
2022-08-03 13:12 ` Vladimir Murzin
2022-08-09 20:16 ` Michael S. Tsirkin
2022-08-10 7:54 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028101111.128049-1-lvivier@redhat.com \
--to=lvivier@redhat.com \
--cc=akong@redhat.com \
--cc=amit@kernel.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®