From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Alex Helms <alexander.helms.jy@renesas.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-clk@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Cc: lkp@intel.com, kbuild-all@lists.01.org, robh+dt@kernel.org,
sboyd@kernel.org, mturquette@baylibre.com,
geert+renesas@glider.be, alexander.helms.jy@renesas.com,
david.cater.jc@renesas.com
Subject: Re: [PATCH v8 2/2] clk: Add ccf driver for Renesas 8T49N241
Date: Wed, 3 Nov 2021 17:57:33 +0300 [thread overview]
Message-ID: <202110281624.lV6hDzvG-lkp@intel.com> (raw)
In-Reply-To: <20211021213106.315-3-alexander.helms.jy@renesas.com>
Hi Alex,
url: https://github.com/0day-ci/linux/commits/Alex-Helms/Renesas-8T49N241-device-driver/20211022-053306
base: 519d81956ee277b4419c723adfb154603c2565ba
config: x86_64-randconfig-m001-20211027 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/clk/8t49n24x-core.c:94 __renesas_i2c_write_bulk() error: uninitialized symbol 'err'.
drivers/clk/8t49n24x.c:416 r8t49n24x_probe() warn: excess argument passed to 'sprintf'
drivers/clk/8t49n24x.c:448 r8t49n24x_probe() warn: inconsistent indenting
vim +/err +94 drivers/clk/8t49n24x-core.c
38bfc1ee0c46d7 Alex Helms 2021-10-21 67 int __renesas_i2c_write_bulk(struct i2c_client *client, struct regmap *map,
38bfc1ee0c46d7 Alex Helms 2021-10-21 68 unsigned int reg, u8 val[], size_t val_count)
38bfc1ee0c46d7 Alex Helms 2021-10-21 69 {
38bfc1ee0c46d7 Alex Helms 2021-10-21 70 u8 block[WRITE_BLOCK_SIZE];
38bfc1ee0c46d7 Alex Helms 2021-10-21 71 unsigned int block_offset = reg;
38bfc1ee0c46d7 Alex Helms 2021-10-21 72 unsigned int i, currentOffset = 0;
38bfc1ee0c46d7 Alex Helms 2021-10-21 73 int err;
38bfc1ee0c46d7 Alex Helms 2021-10-21 74
38bfc1ee0c46d7 Alex Helms 2021-10-21 75 dev_dbg(&client->dev,
38bfc1ee0c46d7 Alex Helms 2021-10-21 76 "I2C->0x%04x : [hex] . First byte: %02x, Second byte: %02x",
38bfc1ee0c46d7 Alex Helms 2021-10-21 77 reg, reg >> 8, reg & 0xFF);
38bfc1ee0c46d7 Alex Helms 2021-10-21 78
38bfc1ee0c46d7 Alex Helms 2021-10-21 79 print_hex_dump_debug("i2c_write_bulk: ", DUMP_PREFIX_NONE,
38bfc1ee0c46d7 Alex Helms 2021-10-21 80 16, 1, val, val_count, false);
38bfc1ee0c46d7 Alex Helms 2021-10-21 81
38bfc1ee0c46d7 Alex Helms 2021-10-21 82 for (i = 0; i < val_count; i++) {
38bfc1ee0c46d7 Alex Helms 2021-10-21 83 block[currentOffset++] = val[i];
38bfc1ee0c46d7 Alex Helms 2021-10-21 84
38bfc1ee0c46d7 Alex Helms 2021-10-21 85 if (i > 0 && (i + 1) % WRITE_BLOCK_SIZE == 0) {
38bfc1ee0c46d7 Alex Helms 2021-10-21 86 err = regmap_bulk_write(map, block_offset, block, WRITE_BLOCK_SIZE);
"err" is not set if val_count is 1 or in a bunch of other success paths.
38bfc1ee0c46d7 Alex Helms 2021-10-21 87 if (err)
38bfc1ee0c46d7 Alex Helms 2021-10-21 88 break;
38bfc1ee0c46d7 Alex Helms 2021-10-21 89 block_offset += WRITE_BLOCK_SIZE;
38bfc1ee0c46d7 Alex Helms 2021-10-21 90 currentOffset = 0;
38bfc1ee0c46d7 Alex Helms 2021-10-21 91 }
38bfc1ee0c46d7 Alex Helms 2021-10-21 92 }
38bfc1ee0c46d7 Alex Helms 2021-10-21 93
38bfc1ee0c46d7 Alex Helms 2021-10-21 @94 if (err == 0 && currentOffset > 0)
38bfc1ee0c46d7 Alex Helms 2021-10-21 95 err = regmap_bulk_write(map, block_offset, block, currentOffset);
38bfc1ee0c46d7 Alex Helms 2021-10-21 96
38bfc1ee0c46d7 Alex Helms 2021-10-21 97 return err;
38bfc1ee0c46d7 Alex Helms 2021-10-21 98 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
next prev parent reply other threads:[~2021-11-03 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 21:31 [PATCH v8 0/2] Renesas 8T49N241 device driver Alex Helms
2021-10-21 21:31 ` [PATCH v8 1/2] dt-bindings: Add binding for Renesas 8T49N241 Alex Helms
2021-10-21 21:31 ` [PATCH v8 2/2] clk: Add ccf driver " Alex Helms
2021-11-03 14:57 ` Dan Carpenter [this message]
2022-02-04 9:36 ` [PATCH v8 0/2] Renesas 8T49N241 device driver Michal Simek
2022-02-04 10:00 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110281624.lV6hDzvG-lkp@intel.com \
--to=dan.carpenter@oracle.com \
--cc=alexander.helms.jy@renesas.com \
--cc=david.cater.jc@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®