From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16440C433F5 for ; Fri, 29 Oct 2021 06:20:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F075C61166 for ; Fri, 29 Oct 2021 06:20:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231992AbhJ2GWo (ORCPT ); Fri, 29 Oct 2021 02:22:44 -0400 Received: from a.mx.secunet.com ([62.96.220.36]:52148 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231774AbhJ2GWm (ORCPT ); Fri, 29 Oct 2021 02:22:42 -0400 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id ADF5420096; Fri, 29 Oct 2021 08:20:12 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sS0P5Eqv-uMV; Fri, 29 Oct 2021 08:20:12 +0200 (CEST) Received: from mailout2.secunet.com (mailout2.secunet.com [62.96.220.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 1596620082; Fri, 29 Oct 2021 08:20:12 +0200 (CEST) Received: from cas-essen-01.secunet.de (unknown [10.53.40.201]) by mailout2.secunet.com (Postfix) with ESMTP id 0C6E980004A; Fri, 29 Oct 2021 08:20:12 +0200 (CEST) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 29 Oct 2021 08:20:11 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 29 Oct 2021 08:20:11 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id A4830318056B; Fri, 29 Oct 2021 08:20:11 +0200 (CEST) Date: Fri, 29 Oct 2021 08:20:11 +0200 From: Steffen Klassert To: luo penghao CC: Herbert Xu , "David S . Miller" , Jakub Kicinski , , , luo penghao , Zeal Robot Subject: Re: [PATCH ipsec-next v2] xfrm: Remove redundant fields and related parentheses Message-ID: <20211029062011.GH3027429@gauss3.secunet.de> References: <20211028023639.9914-1-luo.penghao@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20211028023639.9914-1-luo.penghao@zte.com.cn> X-ClientProxiedBy: cas-essen-01.secunet.de (10.53.40.201) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 28, 2021 at 02:36:39AM +0000, luo penghao wrote: > The variable err is not necessary in such places. It should be revmoved > for the simplicity of the code. This will cause the double parentheses > to be redundant, and the inner parentheses should be deleted. > > The clang_analyzer complains as follows: > > net/xfrm/xfrm_input.c:533: warning: > net/xfrm/xfrm_input.c:563: warning: > > Although the value stored to 'err' is used in the enclosing expression, > the value is never actually read from 'err'. > > Changes in v2: > > Modify the title, because v2 removes the brackets. > Remove extra parentheses. > > Reported-by: Zeal Robot > Signed-off-by: luo penghao Applied, thanks a lot!