From: Steven Rostedt <rostedt@goodmis.org>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: surenb@google.com, hridya@google.com, namhyung@kernel.org,
kernel-team@android.com, mhiramat@kernel.org,
Jonathan Corbet <corbet@lwn.net>, Ingo Molnar <mingo@redhat.com>,
Shuah Khan <shuah@kernel.org>, Tom Zanussi <zanussi@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 1/4] tracing/histogram: Optimize division by constants
Date: Fri, 29 Oct 2021 16:25:49 -0400 [thread overview]
Message-ID: <20211029162549.2c22f2dd@gandalf.local.home> (raw)
In-Reply-To: <CAC_TJve9OsL5taBN0ckgjG4=HxvmWfP6ULwwqnVsDyRxuQuRkg@mail.gmail.com>
On Fri, 29 Oct 2021 11:53:16 -0700
Kalesh Singh <kaleshsingh@google.com> wrote:
> > If these functions are only called when val2 is constant, can't we make it
> > such that we get val2 from the hist_field directly? That is:
> >
> > u64 val2 = operand2->constant;
>
> operand2 might be a var ref to a constant, so we would need to resolve
> that with hist_field_var_ref().
So can a var_ref change? If not, then we should convert that to a constant
for this operation.
-- Steve
next prev parent reply other threads:[~2021-10-29 20:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 18:33 [PATCH 0/4] tracing/histogram: Division optimization and expression kselftests Kalesh Singh
2021-10-29 18:33 ` [PATCH v2 1/4] tracing/histogram: Optimize division by constants Kalesh Singh
2021-10-29 18:45 ` Steven Rostedt
2021-10-29 18:53 ` Kalesh Singh
2021-10-29 19:16 ` Kalesh Singh
2021-10-29 20:25 ` Steven Rostedt [this message]
2021-10-29 22:31 ` Kalesh Singh
2021-10-29 23:24 ` [PATCH v3] " Kalesh Singh
2021-10-29 18:33 ` [PATCH 2/4] tracing/histogram: Update division by 0 documentation Kalesh Singh
2021-10-29 18:33 ` [PATCH v3 3/4] tracing/histogram: Document hist trigger variables Kalesh Singh
2021-10-29 18:33 ` [PATCH v7 4/4] tracing/selftests: Add tests for hist trigger expression parsing Kalesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211029162549.2c22f2dd@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=corbet@lwn.net \
--cc=hridya@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®