From: Jan Kara <jack@suse.cz>
To: cgel.zte@gmail.com
Cc: jack@suse.cz, zhang.mingyu@zte.com.cn, krisman@collabora.com,
amir73il@gmail.com, linux-kernel@vger.kernel.org,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] samples: remove duplicate include in fs-monitor.c
Date: Mon, 1 Nov 2021 13:18:19 +0100 [thread overview]
Message-ID: <20211101121819.GD21679@quack2.suse.cz> (raw)
In-Reply-To: <20211101075152.35780-1-zhang.mingyu@zte.com.cn>
On Mon 01-11-21 07:51:52, cgel.zte@gmail.com wrote:
> From: Zhang Mingyu <zhang.mingyu@zte.com.cn>
>
> 'sys/types.h' included in 'samples/fanotify/fs-monitor.c'
> is duplicated.It is also included on 15 line.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Zhang Mingyu <zhang.mingyu@zte.com.cn>
Thanks. I've added the patch to my tree.
Honza
> ---
> samples/fanotify/fs-monitor.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/samples/fanotify/fs-monitor.c b/samples/fanotify/fs-monitor.c
> index a0e44cd31e6f..0a5f742a77a8 100644
> --- a/samples/fanotify/fs-monitor.c
> +++ b/samples/fanotify/fs-monitor.c
> @@ -12,7 +12,6 @@
> #include <sys/fanotify.h>
> #include <sys/types.h>
> #include <unistd.h>
> -#include <sys/types.h>
>
> #ifndef FAN_FS_ERROR
> #define FAN_FS_ERROR 0x00008000
> --
> 2.25.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2021-11-01 12:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 7:51 cgel.zte
2021-11-01 12:18 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211101121819.GD21679@quack2.suse.cz \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=cgel.zte@gmail.com \
--cc=krisman@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zealci@zte.com.cn \
--cc=zhang.mingyu@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®