From: Xin Ji <xji@analogixsemi.com>
To: Jitao Shi <jitao.shi@mediatek.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Xin Ji <xji@analogixsemi.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, ck.hu@mediatek.com,
stonea168@163.com, huijuan.xie@mediatek.com,
rex-bc.chen@mediatek.com, shuijing.li@mediatek.com
Subject: Re: [PATCH v7 3/3] drm/bridge: anx7625: config hs packets end aligned to avoid screen shift
Date: Tue, 2 Nov 2021 09:56:31 +0800 [thread overview]
Message-ID: <20211102015631.GA2248315@anxtwsw-Precision-3640-Tower> (raw)
In-Reply-To: <a16150b6b10dca4bf961b8e02b5e4d940b98468c.camel@mediatek.com>
On Mon, Nov 01, 2021 at 11:16:15AM +0800, Jitao Shi wrote:
> Hi Xin,
>
> Please help to review the changes in anx7625.c
>
> On Thu, 2021-09-16 at 06:31 +0800, Jitao Shi wrote:
> > This device requires the packets on lanes aligned at the end to fix
> > screen shift or scroll.
> >
> > Signed-off-by: Jitao Shi <jitao.shi@mediatek.com>
> > ---
> > drivers/gpu/drm/bridge/analogix/anx7625.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 14d73fb1dd15..d76fb63fa9f7 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -1327,6 +1327,7 @@ static int anx7625_attach_dsi(struct
> > anx7625_data *ctx)
> > MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> > MIPI_DSI_MODE_NO_EOT_PACKET |
> > MIPI_DSI_MODE_VIDEO_HSE;
> > + dsi->hs_packet_end_aligned = true;
Looks good, it's OK for me.
Reviewed-by: Xin Ji <xji@analogixsemi.com>
> >
> > if (mipi_dsi_attach(dsi) < 0) {
> > DRM_DEV_ERROR(dev, "fail to attach dsi to host.\n");
next prev parent reply other threads:[~2021-11-02 1:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 22:31 [PATCH v7 0/3] force hsa hbp hfp packets multiple of lanenum " Jitao Shi
2021-09-15 22:31 ` [PATCH v7 1/3] drm/dsi: transer dsi hs packet aligned Jitao Shi
2021-10-04 23:53 ` Chun-Kuang Hu
2021-11-04 3:36 ` Jitao Shi
2021-12-10 16:24 ` Chun-Kuang Hu
2021-09-15 22:31 ` [PATCH v7 2/3] drm/mediatek: implment the dsi hs packets aligned Jitao Shi
2021-09-29 14:58 ` Chun-Kuang Hu
2021-09-15 22:31 ` [PATCH v7 3/3] drm/bridge: anx7625: config hs packets end aligned to avoid screen shift Jitao Shi
2021-11-01 3:16 ` Jitao Shi
2021-11-02 1:56 ` Xin Ji [this message]
2021-11-02 10:48 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211102015631.GA2248315@anxtwsw-Precision-3640-Tower \
--to=xji@analogixsemi.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=huijuan.xie@mediatek.com \
--cc=jernej.skrabec@gmail.com \
--cc=jitao.shi@mediatek.com \
--cc=jonas@kwiboo.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rex-bc.chen@mediatek.com \
--cc=robert.foss@linaro.org \
--cc=shuijing.li@mediatek.com \
--cc=stonea168@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®