From: Cai Huoqing <caihuoqing@baidu.com>
To: Xu Wang <vulab@iscas.ac.cn>
Cc: <joel@jms.id.au>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ethernet: litex: Remove unnecessary print function dev_err()
Date: Fri, 5 Nov 2021 11:15:08 +0800 [thread overview]
Message-ID: <20211105031508.GA817@LAPTOP-UKSR4ENP.internal.baidu.com> (raw)
In-Reply-To: <20211105014217.38681-1-vulab@iscas.ac.cn>
On 05 11月 21 01:42:17, Xu Wang wrote:
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>
Reviewed-by: Cai Huoqing <caihuoqing@baidu.com>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
> drivers/net/ethernet/litex/litex_liteeth.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/litex/litex_liteeth.c b/drivers/net/ethernet/litex/litex_liteeth.c
> index 3d9385a4989b..ab9fa1525053 100644
> --- a/drivers/net/ethernet/litex/litex_liteeth.c
> +++ b/drivers/net/ethernet/litex/litex_liteeth.c
> @@ -242,10 +242,8 @@ static int liteeth_probe(struct platform_device *pdev)
> priv->dev = &pdev->dev;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - dev_err(&pdev->dev, "Failed to get IRQ %d\n", irq);
> + if (irq < 0)
> return irq;
> - }
> netdev->irq = irq;
>
> priv->base = devm_platform_ioremap_resource_byname(pdev, "mac");
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-11-05 3:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 1:42 Xu Wang
2021-11-05 3:15 ` Cai Huoqing [this message]
2021-11-05 10:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211105031508.GA817@LAPTOP-UKSR4ENP.internal.baidu.com \
--to=caihuoqing@baidu.com \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®