From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8F36C433F5 for ; Fri, 5 Nov 2021 19:43:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE8E76103B for ; Fri, 5 Nov 2021 19:43:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232329AbhKETps (ORCPT ); Fri, 5 Nov 2021 15:45:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231938AbhKETpm (ORCPT ); Fri, 5 Nov 2021 15:45:42 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3BC8C061205 for ; Fri, 5 Nov 2021 12:43:02 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id f8so11651601plo.12 for ; Fri, 05 Nov 2021 12:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=squVkhv4km3z5tN6L4QImms65JcT1KD/LPFKJ715zrE=; b=QoRz0htecI4xyG+YX3S4YI/eBSENAzqrmpMS9V4vHUMxlFMaeVglFIOUTo4jv2i920 vbVxY9fkUzdU6s2fTpXn4tQ5jsR0kltYIhAWZB5Dv7ycacIjVAhAxagsR/8tSJp6sWx1 l4dSa+8Su3W7Mou3Jz6iTTEhohAsPBFO7Gj2Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=squVkhv4km3z5tN6L4QImms65JcT1KD/LPFKJ715zrE=; b=hwrj/v/6+cRWaIcG8rUu1KqgHmW/8tzytyD2vQvSPd72eNtfvW4FiyWEEXFh1WPYeH /R0ucJqRYuElBdk+HH1I/tOD16dyOeNTnBpI5c3kyogxOPCPG3yq1PcDBXETXsltFWdV NXbcMvkisVAqaw5JOrfvAefePLx8xuoIrP+xEzdNt8uyLhsIb5+Vn6sJGEfPFh2eG8d0 5HSgI2IFPZ5nJppgg08pmpkgk7G+D6KhSXzvXQiue3XAWUczbu6M6KBZtrY4Z8R7oQzT hZGz7efki64kZnpUzNFzzULtzy2GWSSw95TI8e37PLCGQ6UerJJXGUKb8eM/xn+UXDG6 MswA== X-Gm-Message-State: AOAM532wXRcYm7O4pBh0v86ZmpM4lahKPEbO+BLmPdJqehe7SQ1KvEj7 5zjt0y3f5v9wwET9B27qTBDrTA== X-Google-Smtp-Source: ABdhPJyqFiznsCrm8OzYwtY3bHoMdZMaeN3HiGBl7qvfkbukQ4KLiHxJ3sDY1MnVjOLU3T5kxdIhEw== X-Received: by 2002:a17:902:ea11:b0:141:c6c8:823a with SMTP id s17-20020a170902ea1100b00141c6c8823amr40658952plg.29.1636141382220; Fri, 05 Nov 2021 12:43:02 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m26sm3892873pfe.23.2021.11.05.12.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Nov 2021 12:43:01 -0700 (PDT) Date: Fri, 5 Nov 2021 12:43:00 -0700 From: Kees Cook To: Guenter Roeck Cc: Linus Torvalds , Linux Kernel Mailing List , Ard Biesheuvel , Helge Deller , linux-parisc Subject: Re: parisc build failures in mainline kernel Message-ID: <202111051242.86E9DBF@keescook> References: <20211104031554.GA34798@roeck-us.net> <77dc70f4-879a-eb5c-2dd6-682b4c7cfd03@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 03, 2021 at 09:45:47PM -0700, Linus Torvalds wrote: > On Wed, Nov 3, 2021 at 9:30 PM Guenter Roeck wrote: > > > > Unfortunately not. With that patch it complains about task_struct. > > Gaah. You'll need something like this too > > - DEFINE(TASK_CPU, offsetof(struct task_struct, cpu)); > + DEFINE(TASK_CPU, offsetof(struct task_struct, thread_info.cpu)); > > in arch/parisc/kernel/asm-offsets.c. > > And really, it should probably be renamed as TASK_TI_CPU, but then you > have to rename all the uses too. > > There might be other details like that lurking. I'll check this out too if Ard doesn't beat me to it. Thanks for the investigation and sorry for the breakage! -- Kees Cook