From: Pavel Skripkin <paskripkin@gmail.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org, hdanton@sina.com
Cc: linux-kernel@vger.kernel.org, Pavel Skripkin <paskripkin@gmail.com>
Subject: [PATCH] tty: n_gsm: add missing tty_kref_put
Date: Tue, 9 Nov 2021 13:39:30 +0300 [thread overview]
Message-ID: <20211109103930.27494-1-paskripkin@gmail.com> (raw)
My local syzbot instance hit memory leak in gsmld_attach_gsm(). The
reproducer injects allocation failure in tty_register_device(). After
this error only previous tty_register_device() calls unwinded, but not
tty_kref_get().
It leads to tty_struct leak, because ->close() won't be called in case
of ->open() failure and nothing puts tty reference.
Fixes: 0a360e8b65d6 ("tty: n_gsm: check error while registering tty devices")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
---
drivers/tty/n_gsm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index 1d92d2a84889..1cc3aec17d2d 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -2394,6 +2394,8 @@ static int gsmld_attach_gsm(struct tty_struct *tty, struct gsm_mux *gsm)
for (i--; i >= 1; i--)
tty_unregister_device(gsm_tty_driver,
base + i);
+
+ tty_kref_put(gsm->tty);
return PTR_ERR(dev);
}
}
--
2.33.1
next reply other threads:[~2021-11-09 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 10:39 Pavel Skripkin [this message]
2021-11-09 17:33 ` Jiri Slaby
2021-11-09 19:10 ` Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211109103930.27494-1-paskripkin@gmail.com \
--to=paskripkin@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®