From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE9F6C4332F for ; Tue, 9 Nov 2021 15:57:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7D5461208 for ; Tue, 9 Nov 2021 15:57:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238138AbhKIQAm (ORCPT ); Tue, 9 Nov 2021 11:00:42 -0500 Received: from elvis.franken.de ([193.175.24.41]:39311 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237265AbhKIQAl (ORCPT ); Tue, 9 Nov 2021 11:00:41 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mkTVS-0003EX-01; Tue, 09 Nov 2021 16:57:54 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 1477AC2C3B; Tue, 9 Nov 2021 16:32:40 +0100 (CET) Date: Tue, 9 Nov 2021 16:32:40 +0100 From: Thomas Bogendoerfer To: Masahiro Yamada Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] MIPS: fix duplicated slashes for Platform file path Message-ID: <20211109153239.GB13509@alpha.franken.de> References: <20211109150146.529428-1-masahiroy@kernel.org> <20211109150146.529428-2-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211109150146.529428-2-masahiroy@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 10, 2021 at 12:01:46AM +0900, Masahiro Yamada wrote: > platform-y accumulates platform names with a slash appended. > The current $(patsubst ...) ends up with doubling slashes. > > GNU Make still include Platform files, but in case of an error, > a clumsy file path is displayed: > > arch/mips/loongson2ef//Platform:36: *** only binutils >= 2.20.2 have needed option -mfix-loongson2f-nop. Stop. > > Signed-off-by: Masahiro Yamada > --- > > arch/mips/Kbuild.platforms | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/Kbuild.platforms b/arch/mips/Kbuild.platforms > index 2c57994b5217..30193bcf9caa 100644 > --- a/arch/mips/Kbuild.platforms > +++ b/arch/mips/Kbuild.platforms > @@ -37,4 +37,4 @@ platform-$(CONFIG_MACH_TX49XX) += txx9/ > platform-$(CONFIG_MACH_VR41XX) += vr41xx/ > > # include the platform specific files > -include $(patsubst %, $(srctree)/arch/mips/%/Platform, $(platform-y)) > +include $(patsubst %/, $(srctree)/arch/mips/%/Platform, $(platform-y)) > -- > 2.30.2 applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]