From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B7F4C433F5 for ; Tue, 9 Nov 2021 22:44:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 274F760524 for ; Tue, 9 Nov 2021 22:44:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344935AbhKIWrJ (ORCPT ); Tue, 9 Nov 2021 17:47:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:34962 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346245AbhKIWoI (ORCPT ); Tue, 9 Nov 2021 17:44:08 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F21EE61B44; Tue, 9 Nov 2021 22:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636496680; bh=XJpxs3LuAxVLllPTjiLK+XplcoO1soIvLmz6KqklFzc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uA0SWTn8uP113KU3EO8u04GGB4hxgi0D86by5GbFX2RXH+ZEtLeCYUCJM9KgW+nRw M2GmYOY3hBqn0KzSVGgCcY25opJE/+KDA/3kYHwvwMZ+zqUcUbejjF2Ti6SyDKzz4y BDs3jWzNEe8WIqksyb9FEq38FC4/fEJwlNj/LKPdX5PmWuChRu8NlTTnC9G1QlyzIQ i8vEnXMUxU0fL8w3silduIEVBPFwWHzaEHt37FJV/pgTFqgW7OIx8zzd88d8MTai9L SsdGMvU+Y7bcSMrBCH9YXFWXqu8wiarQQrIrSBtwFJreqeK7RNXLKIrcP/j7Xr+ndM MiiS+8zcqb7lw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mike Christie , "Martin K . Petersen" , Sasha Levin , nab@linux-iscsi.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 09/12] scsi: target: Fix alua_tg_pt_gps_count tracking Date: Tue, 9 Nov 2021 17:24:23 -0500 Message-Id: <20211109222426.1236575-9-sashal@kernel.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211109222426.1236575-1-sashal@kernel.org> References: <20211109222426.1236575-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mike Christie [ Upstream commit 1283c0d1a32bb924324481586b5d6e8e76f676ba ] We can't free the tg_pt_gp in core_alua_set_tg_pt_gp_id() because it's still accessed via configfs. Its release must go through the normal configfs/refcount process. The max alua_tg_pt_gps_count check should probably have been done in core_alua_allocate_tg_pt_gp(), but with the current code userspace could have created 0x0000ffff + 1 groups, but only set the id for 0x0000ffff. Then it could have deleted a group with an ID set, and then set the ID for that extra group and it would work ok. It's unlikely, but just in case this patch continues to allow that type of behavior, and just fixes the kfree() while in use bug. Link: https://lore.kernel.org/r/20210930020422.92578-4-michael.christie@oracle.com Signed-off-by: Mike Christie Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/target_core_alua.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/target/target_core_alua.c b/drivers/target/target_core_alua.c index 1fe782f9ee816..f1e09e7704afe 100644 --- a/drivers/target/target_core_alua.c +++ b/drivers/target/target_core_alua.c @@ -1735,7 +1735,6 @@ int core_alua_set_tg_pt_gp_id( pr_err("Maximum ALUA alua_tg_pt_gps_count:" " 0x0000ffff reached\n"); spin_unlock(&dev->t10_alua.tg_pt_gps_lock); - kmem_cache_free(t10_alua_tg_pt_gp_cache, tg_pt_gp); return -ENOSPC; } again: -- 2.33.0