mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pekka Paalanen <ppaalanen@gmail.com>
To: Neal Gompa <ngompa13@gmail.com>
Cc: "Thomas Zimmermann" <tzimmermann@suse.de>,
	"Javier Martinez Canillas" <javierm@redhat.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Peter Robinson" <pbrobinson@gmail.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Michel Dänzer" <michel@daenzer.net>
Subject: Re: [PATCH 2/5] drm: Move nomodeset kernel parameter handler to the DRM subsystem
Date: Wed, 10 Nov 2021 11:04:42 +0200	[thread overview]
Message-ID: <20211110110442.1743b0d2@eldfell> (raw)
In-Reply-To: <CAEg-Je-mmwZOGR-J-dTcOs-8x2BfgCtv5GwFy_d9rBkxOZ1YBg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1608 bytes --]

On Wed, 3 Nov 2021 08:34:20 -0400
Neal Gompa <ngompa13@gmail.com> wrote:

> On Wed, Nov 3, 2021 at 8:32 AM Thomas Zimmermann <tzimmermann@suse.de> wrote:
> >
> > Hi
> >
> > Am 03.11.21 um 12:05 schrieb Neal Gompa:  
> > > On Wed, Nov 3, 2021 at 6:48 AM Javier Martinez Canillas
> > > <javierm@redhat.com> wrote:  
> > >>
> > >> The "nomodeset" kernel cmdline parameter is handled by the vgacon driver
> > >> but the exported vgacon_text_force() symbol is only used by DRM drivers.
> > >>
> > >> It makes much more sense for the parameter logic to be in the subsystem
> > >> of the drivers that are making use of it. Let's move that to DRM.
> > >>
> > >> Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> > >> ---  
> > >
> > > Please no, I'd much rather have a better, more meaningful option
> > > instead of "nomodeset". If anything, I would like this option to
> > > eventually do nothing and replace it with a better named option that's
> > > namespaced by drm on the command-line. That was part of the feedback I
> > > gave in the original patch set, and I still stand by that.  
> >
> > This was nack'ed for now during irc chats with others. There was no
> > clear semantics for the new parameter and nomodeset is good enough for
> > now. I agree that nomodeset is badly named, though.
> >  
> 
> Where are these chats happening? I'm mostly talking to Javier in the
> #devel:fedoraproject.org Matrix room, so I don't know about anything
> else...

OFTC IRC channel #dri-devel


Thanks,
pq

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-11-10  9:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 10:48 [PATCH 0/5] Cleanups for the nomodeset kernel command line parameter logic Javier Martinez Canillas
2021-11-03 10:48 ` [PATCH 1/5] drm/i915: Fix comment about modeset parameters Javier Martinez Canillas
2021-11-03 10:48 ` [PATCH 2/5] drm: Move nomodeset kernel parameter handler to the DRM subsystem Javier Martinez Canillas
2021-11-03 11:05   ` Neal Gompa
2021-11-03 11:21     ` Javier Martinez Canillas
2021-11-03 12:32     ` Thomas Zimmermann
2021-11-03 12:34       ` Neal Gompa
2021-11-10  9:04         ` Pekka Paalanen [this message]
2021-11-03 12:36   ` Thomas Zimmermann
2021-11-03 10:48 ` [PATCH 3/5] drm: Rename vgacon_text_force() function to drm_modeset_disabled() Javier Martinez Canillas
2021-11-03 12:37 ` [PATCH 0/5] Cleanups for the nomodeset kernel command line parameter logic Thomas Zimmermann
2021-11-03 12:40   ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211110110442.1743b0d2@eldfell \
    --to=ppaalanen@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=javierm@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel@daenzer.net \
    --cc=ngompa13@gmail.com \
    --cc=pbrobinson@gmail.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome