From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23E11C4332F for ; Wed, 10 Nov 2021 18:54:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EEA961178 for ; Wed, 10 Nov 2021 18:54:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233328AbhKJS5W (ORCPT ); Wed, 10 Nov 2021 13:57:22 -0500 Received: from elvis.franken.de ([193.175.24.41]:41168 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232912AbhKJSzX (ORCPT ); Wed, 10 Nov 2021 13:55:23 -0500 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mkshy-0005Il-00; Wed, 10 Nov 2021 19:52:30 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id DAD33C2C40; Wed, 10 Nov 2021 19:48:51 +0100 (CET) Date: Wed, 10 Nov 2021 19:48:51 +0100 From: Thomas Bogendoerfer To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , Arnd Bergmann , linux-mips@vger.kernel.org Subject: Re: [PATCH] MIPS: boot/compressed/: add __bswapdi2() to target for ZSTD decompression Message-ID: <20211110184851.GA13827@alpha.franken.de> References: <20211110030944.6733-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211110030944.6733-1-rdunlap@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 09, 2021 at 07:09:44PM -0800, Randy Dunlap wrote: > For MIPS pre-boot, when CONFIG_KERNEL_ZSTD=y, the decompressor > function uses __bswapdi2(), so this object file should be added to > the target object file. > > Fixes these build errors: > > mips-linux-ld: arch/mips/boot/compressed/decompress.o: in function `xxh64': > decompress.c:(.text+0x8be0): undefined reference to `__bswapdi2' > mips-linux-ld: decompress.c:(.text+0x8c78): undefined reference to `__bswapdi2' > mips-linux-ld: decompress.c:(.text+0x8d04): undefined reference to `__bswapdi2' > mips-linux-ld: arch/mips/boot/compressed/decompress.o:decompress.c:(.text+0xa010): more undefined references to `__bswapdi2' follow > > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: Arnd Bergmann > Cc: Thomas Bogendoerfer > Cc: linux-mips@vger.kernel.org > --- > arch/mips/boot/compressed/Makefile | 6 ++++++ > 1 file changed, 6 insertions(+) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]