From: Waiman Long <longman@redhat.com>
To: John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>, Feng Tang <feng.tang@intel.com>,
"Paul E. McKenney" <paulmck@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Cassio Neri <cassio.neri@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Frederic Weisbecker <frederic@kernel.org>,
Waiman Long <longman@redhat.com>
Subject: [PATCH v2 2/4] clocksource: Reduce the default clocksource_watchdog() retries to 2
Date: Tue, 16 Nov 2021 18:44:24 -0500 [thread overview]
Message-ID: <20211116234426.837799-3-longman@redhat.com> (raw)
In-Reply-To: <20211116234426.837799-1-longman@redhat.com>
With the previous patch, there is an extra watchdog read in each retry.
Now the total number of clocksource reads is increased to 4 per iteration.
In order to avoid increasing the clock skew check overhead, the default
maximum number of retries is reduced from 3 to 2 to maintain the same 12
clocksource reads in the worst case.
Suggested-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Waiman Long <longman@redhat.com>
---
Documentation/admin-guide/kernel-parameters.txt | 4 ++--
kernel/time/clocksource.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index 9725c546a0d4..3ea934b034f7 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -603,8 +603,8 @@
clocksource.max_cswd_read_retries= [KNL]
Number of clocksource_watchdog() retries due to
external delays before the clock will be marked
- unstable. Defaults to three retries, that is,
- four attempts to read the clock under test.
+ unstable. Defaults to two retries, that is,
+ three attempts to read the clock under test.
clocksource.verify_n_cpus= [KNL]
Limit the number of CPUs checked for clocksources
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index a5c2b130adbf..a7814b543a9b 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -199,7 +199,7 @@ void clocksource_mark_unstable(struct clocksource *cs)
spin_unlock_irqrestore(&watchdog_lock, flags);
}
-ulong max_cswd_read_retries = 3;
+ulong max_cswd_read_retries = 2;
module_param(max_cswd_read_retries, ulong, 0644);
EXPORT_SYMBOL_GPL(max_cswd_read_retries);
static int verify_n_cpus = 8;
--
2.27.0
next prev parent reply other threads:[~2021-11-16 23:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 23:44 [PATCH v2 0/4] clocksource: Avoid incorrect hpet fallback Waiman Long
2021-11-16 23:44 ` [PATCH v2 1/4] clocksource: Avoid accidental unstable marking of clocksources Waiman Long
2021-11-16 23:44 ` Waiman Long [this message]
2021-11-16 23:44 ` [PATCH v2 3/4] clocksource: Dynamically increase watchdog_max_skew Waiman Long
2021-11-16 23:44 ` [PATCH v2 4/4] clocksource: Add a Kconfig option for WATCHDOG_MAX_SKEW Waiman Long
2021-11-17 16:54 ` [PATCH v2 0/4] clocksource: Avoid incorrect hpet fallback Paul E. McKenney
2021-11-17 18:51 ` Waiman Long
2021-11-17 21:25 ` Paul E. McKenney
2021-11-17 21:55 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211116234426.837799-3-longman@redhat.com \
--to=longman@redhat.com \
--cc=cassio.neri@gmail.com \
--cc=feng.tang@intel.com \
--cc=frederic@kernel.org \
--cc=john.stultz@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®