mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rocco Yue <rocco.yue@mediatek.com>
To: Jakub Kicinski <kuba@kernel.org>, David Ahern <dsahern@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jonathan Corbet <corbet@lwn.net>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>, <Rocco.Yue@gmail.com>,
	<chao.song@mediatek.com>, <yanjie.jiang@mediatek.com>,
	<kuohong.wang@mediatek.com>, <zhuoliang.zhang@mediatek.com>,
	<lorenzo@google.com>, <maze@google.com>, <markzzzsmith@gmail.com>,
	Rocco Yue <rocco.yue@mediatek.com>
Subject: Re: [PATCH net-next] ipv6: don't generate link-local addr in random or privacy mode
Date: Wed, 17 Nov 2021 13:59:30 +0800	[thread overview]
Message-ID: <20211117055930.6810-1-rocco.yue@mediatek.com> (raw)

On Wed, 2021-11-17 at 11:34 +0800, Jakub Kicinski wrote:
> On Tue, 16 Nov 2021 13:21:12 -0700 David Ahern wrote:
>> Reviewed-by: David Ahern <dsahern@kernel.org>
>>
>> you should add tests under tools/testing/selftests/net.
>
> Please keep David's review tag and repost with a selftest.

Hi David and Jakub,

Thanks for your review. :-)

I heard about selftest for the first time, and I am thinking
about how to write a selftest for this patch, and I will
repost thses patches again when finished.

Thanks,

Rocco


             reply	other threads:[~2021-11-17  6:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17  5:59 Rocco Yue [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-11-17  5:09 [PATCH net-next v2] " Lorenzo Colitti
2021-11-17  7:17 ` [PATCH net-next] " Rocco Yue
2021-11-17  8:36   ` Lorenzo Colitti
2021-11-17  9:50     ` Maciej Żenczykowski
2021-11-09  6:55 Rocco Yue
2021-11-13  8:46 ` Rocco Yue
2021-11-13 16:34   ` David Ahern
2021-11-16  2:21     ` Rocco Yue
2021-11-16  2:40       ` David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211117055930.6810-1-rocco.yue@mediatek.com \
    --to=rocco.yue@mediatek.com \
    --cc=20211116193456.54436652@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --cc=Rocco.Yue@gmail.com \
    --cc=chao.song@mediatek.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuohong.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lorenzo@google.com \
    --cc=markzzzsmith@gmail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=maze@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=yanjie.jiang@mediatek.com \
    --cc=yoshfuji@linux-ipv6.org \
    --cc=zhuoliang.zhang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®