mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Nikita Yushchenko <nikita.yushchenko@virtuozzo.com>
Cc: Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, kernel@openvz.org
Subject: Re: [PATCH] tracing: fix va_list breakage in trace_check_vprintf()
Date: Thu, 18 Nov 2021 09:30:32 -0500	[thread overview]
Message-ID: <20211118093032.31c06b11@gandalf.local.home> (raw)
In-Reply-To: <ae2254dd-dcc8-3375-e8d6-efb73e280574@virtuozzo.com>

On Thu, 18 Nov 2021 07:57:33 +0300
Nikita Yushchenko <nikita.yushchenko@virtuozzo.com> wrote:

> What I don't like here is - trace_check_vprintf() will still extract wrong positional arguments, and use 
> the result as part of it's logic.
> 
> Although with your change such use becomes a no-op, this is unintuitive and can turn easily into real 
> problems with future changes.

That trace_check_vprintf() is just full of unintuitive logic ;-)

Which is why I prefer to keep any remnants of that code in that code and
not spread it around. 

> 
> And, the above comment is inexact...  why we can't test? We can, testing code does no depend on 
> iter->seq. What we can't is - reliably extract str to test.
> 
> If testing seq->full condition is preferred over forcibly consuming args from va_list, then such a test 
> shall be done before trace_check_vprintf() tries to use va_arg(). Will submit a patch doing that.

I'm happy with that patch, but can you please resend it as a top level
patch and not a reply, otherwise my patchwork doesn't catch it and my
scripts will not work on it.

Thanks,

-- Steve

  parent reply	other threads:[~2021-11-18 14:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 18:37 Nikita Yushchenko
2021-11-17 23:38 ` Steven Rostedt
2021-11-17 23:41   ` Steven Rostedt
2021-11-18  4:57   ` Nikita Yushchenko
2021-11-18  5:44     ` [PATCH] trace: don't use out-of-sync va_list in event printing Nikita Yushchenko
2021-11-18 14:30     ` Steven Rostedt [this message]
2021-11-18 14:54       ` [PATCH] tracing: fix va_list breakage in trace_check_vprintf() Nikita Yushchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211118093032.31c06b11@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=kernel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nikita.yushchenko@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®